Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-23 Thread Michael Tokarev
23.01.2013 17:54, Kevin Wolf wrote: [] > Not sure if a stable branch for 1.1 is still maintained, but I'm copying > qemu-stable just in case. Commit b7ab0fea actually fixes a qcow2 data > corruption issue (even though under rare circumstances) and should > definitely be cherry-picked for any new 1.

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-23 Thread Kevin Wolf
Am 23.01.2013 12:43, schrieb Kevin Wolf: > Am 22.01.2013 15:14, schrieb Kevin Wolf: >> The series of requests to get into this state is somewhat tricky as it >> requires a specific physical ordering of clusters in the image file: >> >> Host cluster h: Guest cluster g is mapped to here >> Host c

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-23 Thread Kevin Wolf
Am 22.01.2013 15:14, schrieb Kevin Wolf: > The series of requests to get into this state is somewhat tricky as it > requires a specific physical ordering of clusters in the image file: > > Host cluster h: Guest cluster g is mapped to here > Host cluster h + 1: Free, can be allocated for not ye

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-22 Thread Kevin Wolf
Am 22.01.2013 14:17, schrieb Laszlo Ersek: > As I understand it, the question is not whether b7ab0fea works or not > (it does), the question is whether *without* b7ab0fea there is a real > problem (user visible bug). Correct. Or actually not whether, but why. > Commit b7ab0fea decreased "avail_se

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-22 Thread Laszlo Ersek
On 01/22/13 11:25, Kevin Wolf wrote: > Am 18.12.2012 10:46, schrieb Philipp Hahn: >> Hello Kevin, hello Michael, >> >> On Wednesday 12 December 2012 17:54:58 Kevin Wolf wrote: >>> Am 12.12.2012 15:09, schrieb Philipp Hahn: Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: > As you

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2013-01-22 Thread Kevin Wolf
Am 18.12.2012 10:46, schrieb Philipp Hahn: > Hello Kevin, hello Michael, > > On Wednesday 12 December 2012 17:54:58 Kevin Wolf wrote: >> Am 12.12.2012 15:09, schrieb Philipp Hahn: >>> Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: As you can see in the commit message of that patch

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-18 Thread Michael Tokarev
On 18.12.2012 13:46, Philipp Hahn wrote: > I think I found your missing link: > After filling in "QCowL2Meta *m", that request ist queued: > QLIST_INSERT_HEAD(&s->cluster_allocs, m, next_in_flight); > do prevent double allocating the same cluster for overlapping requests, which > is checked in

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-18 Thread Philipp Hahn
Hello Kevin, hello Michael, On Wednesday 12 December 2012 17:54:58 Kevin Wolf wrote: > Am 12.12.2012 15:09, schrieb Philipp Hahn: > > Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: > >> As you can see in the commit message of that patch I was convinced that > >> no bug did exist in prac

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-14 Thread Philipp Hahn
Hello Kevin, On Wednesday 12 December 2012 18:29:48 Philipp Hahn wrote: > I just re-run my "git bisect run ~/bisect.sh" case, but it again arrived > at that patch. I just queued another run for tonight so make sure the test > is reliable: The run from last night again arrived at the refecenced p

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Philipp Hahn
Hello Kevin, Am Mittwoch 12 Dezember 2012 17:54:58 schrieb Kevin Wolf: > Am 12.12.2012 15:09, schrieb Philipp Hahn: > > Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: > >> As you can see in the commit message of that patch I was convinced that > >> no bug did exist in practice and this

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Kevin Wolf
Am 12.12.2012 15:09, schrieb Philipp Hahn: > Hello Kevin, > > Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: >> As you can see in the commit message of that patch I was convinced that >> no bug did exist in practice and this was only dangerous with respect to >> future changes. Therefo

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Philipp Hahn
Hello Kevin, Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: > As you can see in the commit message of that patch I was convinced that > no bug did exist in practice and this was only dangerous with respect to > future changes. Therefore my first question is if you're using an > unmodif

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Kevin Wolf
Hi Philipp, Am 12.12.2012 14:25, schrieb Philipp Hahn: > Hello Kevin, hello Michael, hello *, > > we noticed a data corruption bug in qemu-1.1.2, which will be shipped by > Debian and our own Debian based distibution. > The corruption mostly manifests while installing large Debian package files

[Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Philipp Hahn
Hello Kevin, hello Michael, hello *, we noticed a data corruption bug in qemu-1.1.2, which will be shipped by Debian and our own Debian based distibution. The corruption mostly manifests while installing large Debian package files and seems to be reladed to memory preasure: As long as the file i