Re: [Qemu-devel] [Nbd] [PATCH 1/3] NBD proto: forbid TRIM command without negotiation

2016-03-29 Thread Eric Blake
On 03/29/2016 01:22 AM, Wouter Verhelst wrote: >>> +++ b/doc/proto.md >>> @@ -471,6 +471,9 @@ The following request types exist: >>> about the contents of the export affected by this command, until >>> overwriting it again with `NBD_CMD_WRITE`. >>> >>> +A client MUST NOT send a

Re: [Qemu-devel] [Nbd] [PATCH 1/3] NBD proto: forbid TRIM command without negotiation

2016-03-29 Thread Wouter Verhelst
On Mon, Mar 28, 2016 at 07:00:17AM -0600, Eric Blake wrote: > On 03/28/2016 04:43 AM, Denis V. Lunev wrote: > > From: Pavel Borzenkov > > > > There is a loophole in the protocol that allows a client to send TRIM > > request even if support for it wasn't negotiated with