Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

2016-04-06 Thread Alex Bligh
On 5 Apr 2016, at 22:26, Eric Blake wrote: > In particular, I had a question about the ideal layout of the data in > NBD_REP_SERVER; I'd like some discussion on that point before posting a > cleanup patch. Hmmm... Yes. In particular: > NBD_REP_SERVER (2) > > A description of an export. Data:

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

2016-04-05 Thread Alex Bligh
Eric (sic - sorry - long day). On 5 Apr 2016, at 22:26, Eric Blake wrote: > Ah, you were faster than my reply mail; looks like everything I pointed > out now gets to be a followup patch :) I agree with all but one of the the changes you put in. As Wouter is the fastest gun in the west ( :-) ),

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

2016-04-05 Thread Eric Blake
On 04/05/2016 03:03 PM, Wouter Verhelst wrote: > On Tue, Apr 05, 2016 at 09:42:26PM +0100, Alex Bligh wrote: >> Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as >> follows: >> >> >> * Make the documentation much more concise. >> >> Signed-off-by: Alex Bligh > [...] > > applied, thanks.

Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation

2016-04-05 Thread Wouter Verhelst
On Tue, Apr 05, 2016 at 09:42:26PM +0100, Alex Bligh wrote: > Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as > follows: > > * Change NBD_OPT_SELECT to be called NBD_OPT_INFO > > * Remove the 'selection' aspect of that command, so that > it now merely returns information. This is to av