Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread Boris Fiuczynski
On 09/26/2017 11:14 AM, Yi Min Zhao wrote: 在 2017/9/25 下午7:47, Christian Borntraeger 写道: On 09/25/2017 01:45 PM, Cornelia Huck wrote: On Mon, 25 Sep 2017 12:12:49 +0200 Christian Borntraeger wrote: On 09/25/2017 12:07 PM, Cornelia Huck wrote: On Fri, 22 Sep 2017

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread Christian Borntraeger
On 09/26/2017 02:29 PM, Christian Borntraeger wrote: > > > On 09/26/2017 02:23 PM, David Hildenbrand wrote: >> On 22.09.2017 10:38, Christian Borntraeger wrote: >>> Instead of unconditionally enabling the KVM AIS capability >>> in the kvm arch init function, do this in the flic realize

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread David Hildenbrand
On 26.09.2017 14:29, Christian Borntraeger wrote: > > > On 09/26/2017 02:23 PM, David Hildenbrand wrote: >> On 22.09.2017 10:38, Christian Borntraeger wrote: >>> Instead of unconditionally enabling the KVM AIS capability >>> in the kvm arch init function, do this in the flic realize function >>>

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread Christian Borntraeger
On 09/26/2017 02:23 PM, David Hildenbrand wrote: > On 22.09.2017 10:38, Christian Borntraeger wrote: >> Instead of unconditionally enabling the KVM AIS capability >> in the kvm arch init function, do this in the flic realize function >> when we know if migration is available. This requires to

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread David Hildenbrand
On 22.09.2017 10:38, Christian Borntraeger wrote: > Instead of unconditionally enabling the KVM AIS capability > in the kvm arch init function, do this in the flic realize function > when we know if migration is available. This requires to initialize > flic before the CPUs. > > Signed-off-by:

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread Yi Min Zhao
在 2017/9/25 下午7:47, Christian Borntraeger 写道: On 09/25/2017 01:45 PM, Cornelia Huck wrote: On Mon, 25 Sep 2017 12:12:49 +0200 Christian Borntraeger wrote: On 09/25/2017 12:07 PM, Cornelia Huck wrote: On Fri, 22 Sep 2017 16:27:00 +0200 Halil Pasic

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-25 Thread Christian Borntraeger
On 09/25/2017 01:45 PM, Cornelia Huck wrote: > On Mon, 25 Sep 2017 12:12:49 +0200 > Christian Borntraeger wrote: > >> On 09/25/2017 12:07 PM, Cornelia Huck wrote: >>> On Fri, 22 Sep 2017 16:27:00 +0200 >>> Halil Pasic wrote: >>> One

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-25 Thread Cornelia Huck
On Mon, 25 Sep 2017 12:12:49 +0200 Christian Borntraeger wrote: > On 09/25/2017 12:07 PM, Cornelia Huck wrote: > > On Fri, 22 Sep 2017 16:27:00 +0200 > > Halil Pasic wrote: > > > >> One thing I would find very helpful is what do we expect to

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-25 Thread Christian Borntraeger
On 09/25/2017 12:07 PM, Cornelia Huck wrote: > On Fri, 22 Sep 2017 16:27:00 +0200 > Halil Pasic wrote: > >> One thing I would find very helpful is what do we expect to work and not >> work for which version. Kind of a matrix. For instance should vfio pci >> work for

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-25 Thread Cornelia Huck
On Fri, 22 Sep 2017 16:27:00 +0200 Halil Pasic wrote: > One thing I would find very helpful is what do we expect to work and not > work for which version. Kind of a matrix. For instance should vfio pci > work for versions prior 2.11. I think in the not so distant past

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Pierre Morel
On 22/09/2017 16:07, Christian Borntraeger wrote: On 09/22/2017 04:02 PM, Pierre Morel wrote: On 22/09/2017 14:40, Christian Borntraeger wrote: On 09/22/2017 02:13 PM, Pierre Morel wrote: On 22/09/2017 10:38, Christian Borntraeger wrote: Instead of unconditionally enabling the KVM AIS

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Halil Pasic
On 09/22/2017 04:07 PM, Christian Borntraeger wrote: > > > On 09/22/2017 04:02 PM, Pierre Morel wrote: >> On 22/09/2017 14:40, Christian Borntraeger wrote: >>> >>> >>> On 09/22/2017 02:13 PM, Pierre Morel wrote: On 22/09/2017 10:38, Christian Borntraeger wrote: > Instead of

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Christian Borntraeger
On 09/22/2017 04:02 PM, Pierre Morel wrote: > On 22/09/2017 14:40, Christian Borntraeger wrote: >> >> >> On 09/22/2017 02:13 PM, Pierre Morel wrote: >>> On 22/09/2017 10:38, Christian Borntraeger wrote: Instead of unconditionally enabling the KVM AIS capability in the kvm arch init

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Pierre Morel
On 22/09/2017 14:40, Christian Borntraeger wrote: On 09/22/2017 02:13 PM, Pierre Morel wrote: On 22/09/2017 10:38, Christian Borntraeger wrote: Instead of unconditionally enabling the KVM AIS capability in the kvm arch init function, do this in the flic realize function when we know if

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Cornelia Huck
On Fri, 22 Sep 2017 14:40:31 +0200 Christian Borntraeger wrote: > On 09/22/2017 02:13 PM, Pierre Morel wrote: > > On 22/09/2017 10:38, Christian Borntraeger wrote: > >> Instead of unconditionally enabling the KVM AIS capability > >> in the kvm arch init function, do

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Christian Borntraeger
On 09/22/2017 02:13 PM, Pierre Morel wrote: > On 22/09/2017 10:38, Christian Borntraeger wrote: >> Instead of unconditionally enabling the KVM AIS capability >> in the kvm arch init function, do this in the flic realize function >> when we know if migration is available. This requires to

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Pierre Morel
On 22/09/2017 10:38, Christian Borntraeger wrote: Instead of unconditionally enabling the KVM AIS capability in the kvm arch init function, do this in the flic realize function when we know if migration is available. This requires to initialize flic before the CPUs. I am not sure to agree.

[Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Christian Borntraeger
Instead of unconditionally enabling the KVM AIS capability in the kvm arch init function, do this in the flic realize function when we know if migration is available. This requires to initialize flic before the CPUs. Signed-off-by: Christian Borntraeger ---