Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-21 Thread Peter Maydell
On 21 March 2013 00:36, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-20三的 10:50 +,Peter Maydell写道: The devices should just implement appropriate signals/connections if they have a means of talking to a power controller, and the board model should wire them up. That's all. Hmm, can

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-21 Thread li guang
在 2013-03-21四的 10:41 +,Peter Maydell写道: On 21 March 2013 00:36, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-20三的 10:50 +,Peter Maydell写道: The devices should just implement appropriate signals/connections if they have a means of talking to a power controller, and the board

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-20 Thread Peter Maydell
On 20 March 2013 00:56, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-19二的 10:15 +,Peter Maydell写道: The point is that how exactly power controllers connect to devices, and which devices respond to reset/suspend/etc is a property of the individual machine being modelled. An x86 PC will

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-20 Thread li guang
在 2013-03-20三的 10:50 +,Peter Maydell写道: On 20 March 2013 00:56, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-19二的 10:15 +,Peter Maydell写道: The point is that how exactly power controllers connect to devices, and which devices respond to reset/suspend/etc is a property of the

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-19 Thread Peter Maydell
On 19 March 2013 00:55, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-18一的 11:07 +,Peter Maydell写道: I'm really dubious that this can or should be implemented by adding methods at the device base class level. I don't think real hardware works this way. and what it should be? You

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-19 Thread li guang
在 2013-03-19二的 09:05 +,Peter Maydell写道: On 19 March 2013 00:55, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-18一的 11:07 +,Peter Maydell写道: I'm really dubious that this can or should be implemented by adding methods at the device base class level. I don't think real hardware

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-19 Thread Peter Maydell
On 19 March 2013 09:31, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-19二的 09:05 +,Peter Maydell写道: I suspect this should involve more modelling of actual control signals between the power controller and the devices, not methods on the base class. do we have to realize something

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-19 Thread li guang
在 2013-03-19二的 10:15 +,Peter Maydell写道: On 19 March 2013 09:31, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-19二的 09:05 +,Peter Maydell写道: I suspect this should involve more modelling of actual control signals between the power controller and the devices, not methods on the

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread li guang
ping ... 在 2013-03-15五的 08:59 +0800,li guang写道: Hi, Anthony Sorry to bother you, can you please help to see it this work is worth to go on, or ... or someone else can help to see this patch-set. Thanks All. 在 2013-03-13三的 16:01 +0800,liguang写道: By now, all devices of QEMU do

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread Andreas Färber
Am 13.03.2013 09:01, schrieb liguang: Li Guang (14) gitignore: ignore more files qdev: add power management method qdev: remove redundant abort() qdev: add power on/off/suspend/wakeup handler power: add power chip emulation This patch seems to be missing,

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread li guang
在 2013-03-18一的 09:34 +0100,Andreas Färber写道: Am 13.03.2013 09:01, schrieb liguang: Li Guang (14) gitignore: ignore more files qdev: add power management method qdev: remove redundant abort() qdev: add power on/off/suspend/wakeup handler power: add power chip

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread Peter Maydell
On 13 March 2013 08:01, liguang lig.f...@cn.fujitsu.com wrote: By now, all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required, and the code to do power management state

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread li guang
在 2013-03-18一的 11:07 +,Peter Maydell写道: On 13 March 2013 08:01, liguang lig.f...@cn.fujitsu.com wrote: By now, all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required,

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-14 Thread li guang
Hi, Anthony Sorry to bother you, can you please help to see it this work is worth to go on, or ... or someone else can help to see this patch-set. Thanks All. 在 2013-03-13三的 16:01 +0800,liguang写道: By now, all devices of QEMU do not have much more power management consideration, for example,

[Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-13 Thread liguang
By now, all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required, and the code to do power management state transition seems just do 'ugly emulation', rather than be conscious with