Re: [Qemu-devel] [PATCH][v8] megasas: LSI Megaraid SAS HBA emulation

2012-01-13 Thread Paolo Bonzini
On 01/13/2012 10:46 AM, Hannes Reinecke wrote: So, I should be removing the 'disable' keyword, then, correct? Yes. The strings are just there to avoid trace statement duplication. But if that's not a problem then I can easily convert the strings to individual trace statements. No, don't bot

Re: [Qemu-devel] [PATCH][v8] megasas: LSI Megaraid SAS HBA emulation

2012-01-13 Thread Hannes Reinecke
On 01/12/2012 07:04 PM, Stefan Hajnoczi wrote: > On Thu, Jan 12, 2012 at 03:45:59PM +0100, Paolo Bonzini wrote: >> On 01/12/2012 11:43 AM, Hannes Reinecke wrote: >>> +# hw/megasas.c >>> +disable megasas_init_firmware(int xfer_len, uint64_t pa) "xfer len %d pa >>> %" PRIx64 " " >>> +disable megasas

Re: [Qemu-devel] [PATCH][v8] megasas: LSI Megaraid SAS HBA emulation

2012-01-13 Thread Stefan Hajnoczi
On Thu, Jan 12, 2012 at 03:45:59PM +0100, Paolo Bonzini wrote: > On 01/12/2012 11:43 AM, Hannes Reinecke wrote: > >+# hw/megasas.c > >+disable megasas_init_firmware(int xfer_len, uint64_t pa) "xfer len %d pa %" > >PRIx64 " " > >+disable megasas_init_queue(uint64_t queue_pa, int queue_len, uint64_t

Re: [Qemu-devel] [PATCH][v8] megasas: LSI Megaraid SAS HBA emulation

2012-01-12 Thread Paolo Bonzini
On 01/12/2012 11:43 AM, Hannes Reinecke wrote: +# hw/megasas.c +disable megasas_init_firmware(int xfer_len, uint64_t pa) "xfer len %d pa %" PRIx64 " " +disable megasas_init_queue(uint64_t queue_pa, int queue_len, uint64_t head, uint64_t tail, uint32_t flags) "queue at %" PRIx64 " len %d head %"