Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Blue Swirl
On 11/30/07, Paul Brook <[EMAIL PROTECTED]> wrote: > > I think T2 may need to store host addresses as well. To be frank, I > > don't understand that part but there is a compiler warning on a 64 > > bit host. > > If you're thinking of the warnings in op_goto_tb0, these are actually due to > tb->tb_

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Paul Brook
> I think T2 may need to store host addresses as well. To be frank, I > don't understand that part but there is a compiler warning on a 64 > bit host. If you're thinking of the warnings in op_goto_tb0, these are actually due to tb->tb_next having the wrong type. > > In general all access to tar

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Blue Swirl
On 11/30/07, Paul Brook <[EMAIL PROTECTED]> wrote: > > > target_phys_addr_t = physical address of the host > > > ram_addr_t = physical address of the guest > > > > No, target_phys_addr_t is the physical address of the emulated target > > system. For host addresses ram_addr_t, unsigned long or e

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Paul Brook
> > target_phys_addr_t = physical address of the host > > ram_addr_t = physical address of the guest > > No, target_phys_addr_t is the physical address of the emulated target > system. For host addresses ram_addr_t, unsigned long or even int is > used. Host addresses are of course virtual, Qemu

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Carlo Marcelo Arenas Belon
On Fri, Nov 30, 2007 at 05:37:35PM +0200, Blue Swirl wrote: > On 11/30/07, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > > which might not be what was intended originally and might be uncovering a > > bug somewhere else and based on the fact that apparently (and this gets > > confusing a

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Blue Swirl
On 11/30/07, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Fri, Nov 30, 2007 at 02:36:32PM +0900, Magnus Damm wrote: > > On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon > > <[EMAIL PROTECTED]> wrote: > > > The following patch changes the formatting string from %08x to > > > TARGET

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-30 Thread Carlo Marcelo Arenas Belon
On Fri, Nov 30, 2007 at 02:36:32PM +0900, Magnus Damm wrote: > On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon > <[EMAIL PROTECTED]> wrote: > > The following patch changes the formatting string from %08x to > > TARGET_FMT_plx > > to accommodate for compilation in 64bit hosts and that manifests

Re: [Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-29 Thread Magnus Damm
On Nov 19, 2007 6:18 AM, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > The following patch changes the formatting string from %08x to TARGET_FMT_plx > to accommodate for compilation in 64bit hosts and that manifests with the > following warning : > > qemu/hw/sh7750.c: In function `error

[Qemu-devel] [PATCH] [RESEND] hw/sh7750.c: use TARGET_FMT_plx to printf target_phys_addr_t

2007-11-18 Thread Carlo Marcelo Arenas Belon
The following patch changes the formatting string from %08x to TARGET_FMT_plx to accommodate for compilation in 64bit hosts and that manifests with the following warning : qemu/hw/sh7750.c: In function `error_access': qemu/hw/sh7750.c:186: warning: unsigned int format, different type arg (arg