Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Lluís
Lluís writes: > Michael Roth writes: >> Hmm, looking again I'm confused why we need to do this in the first >> place...the >> rule is: >> LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o >> $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@") >> %$(EXESUF): %.o >> $(call LINK,$^

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Blue Swirl
On Tue, Aug 30, 2011 at 9:22 AM, Stefan Hajnoczi wrote: > On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth > wrote: >> @@ -380,7 +381,6 @@ else >>  trace-obj-y = trace.o >>  ifeq ($(TRACE_BACKEND),simple) >>  trace-obj-y += simpletrace.o >> -user-obj-y += qemu-timer-common.o >>  endif >>  endif > >

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Lluís
Michael Roth writes: > Hmm, looking again I'm confused why we need to do this in the first > place...the > rule is: > LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o > $@ $(1) $(LIBS)," LINK $(TARGET_DIR)$@") > %$(EXESUF): %.o > $(call LINK,$^) > According to the

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Michael Roth
On 08/30/2011 07:02 AM, Lluís wrote: Stefan Hajnoczi writes: On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote: @@ -380,7 +381,6 @@ else trace-obj-y = trace.o ifeq ($(TRACE_BACKEND),simple) trace-obj-y += simpletrace.o -user-obj-y += qemu-timer-common.o endif endif Now that we

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Anthony Liguori
On 08/30/2011 04:22 AM, Stefan Hajnoczi wrote: On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote: @@ -380,7 +381,6 @@ else trace-obj-y = trace.o ifeq ($(TRACE_BACKEND),simple) trace-obj-y += simpletrace.o -user-obj-y += qemu-timer-common.o endif endif Now that we have a concrete p

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Lluís
Stefan Hajnoczi writes: > On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth > wrote: >> @@ -380,7 +381,6 @@ else >>  trace-obj-y = trace.o >>  ifeq ($(TRACE_BACKEND),simple) >>  trace-obj-y += simpletrace.o >> -user-obj-y += qemu-timer-common.o >>  endif >>  endif > Now that we have a concrete patc

Re: [Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-30 Thread Stefan Hajnoczi
On Mon, Aug 29, 2011 at 8:27 PM, Michael Roth wrote: > @@ -380,7 +381,6 @@ else >  trace-obj-y = trace.o >  ifeq ($(TRACE_BACKEND),simple) >  trace-obj-y += simpletrace.o > -user-obj-y += qemu-timer-common.o >  endif >  endif Now that we have a concrete patch to look at I think this approach is p

[Qemu-devel] [PATCH] Add CONFIG_QEMU_TIMER to handle qemu-timer-common.o dep

2011-08-29 Thread Michael Roth
This conditionally sets CONFIG_QEMU_TIMER in configure when something like --enable-trace-backend=simple is set which requires qemu-timer-common.o. Object groups dependent on such code can then simply do: x-obj-$(CONFIG_QEMU_TIMER) += qemu-timer-common.o This also fixes build issue with qemu-ga d