[Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-21 Thread Ronnie Sahlberg
List, Please find a patch that adds built-in iSCSI support to QEMU when built and linked against the multiplatform iscsi initiator library at git://github.com/sahlberg/libiscsi.git I have implemented all suggested changed from Stefans review, except * Fail the build if qemu blocksize is

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-18 Thread Paolo Bonzini
On 09/17/2011 09:08 PM, Laurent Vivier wrote: The NBD protocol supports multiple named exports, just not QEMU's implementation. Named exports are supported since commit 1d45f8b542f6b80b24c44533ef0dd9e1a3b17ea5 Yes, not in the qemu-nbd server though. Paolo

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-17 Thread Laurent Vivier
Le jeudi 15 septembre 2011 à 08:06 +0200, Paolo Bonzini a écrit : On 09/14/2011 06:36 PM, Orit Wasserman wrote: I think NBD would be fine, especially with a flush command. I think NBD would be fine, especially with a flush command. If I remember correctly , there is a problem with NBD

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Paolo Bonzini
On 09/14/2011 06:36 PM, Orit Wasserman wrote: I think NBD would be fine, especially with a flush command. I think NBD would be fine, especially with a flush command. If I remember correctly , there is a problem with NBD with an image with a backing file chain . NBD client only displays a

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Paolo Bonzini
On 09/15/2011 11:52 AM, Orit Wasserman wrote: The NBD protocol supports multiple named exports, just not QEMU's implementation. I guess we can fix that. Yes, or just use Unix sockets and rely on libvirt to tunnel/multiplex the NBD streams. Paolo

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-15 Thread Kevin Wolf
Am 15.09.2011 11:55, schrieb Paolo Bonzini: On 09/15/2011 11:52 AM, Orit Wasserman wrote: The NBD protocol supports multiple named exports, just not QEMU's implementation. I guess we can fix that. Yes, or just use Unix sockets and rely on libvirt to tunnel/multiplex the NBD streams. I

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Orit Wasserman
Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) Ronnie , are you looking into ISCSI target too? Orit On Mon, 2011-09-12 at 10:56 +0200, Kevin

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Christoph Hellwig
On Wed, Sep 14, 2011 at 03:24:38PM +0300, Orit Wasserman wrote: Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) Ronnie , are you looking into

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Christoph Hellwig
On Wed, Sep 14, 2011 at 03:24:38PM +0300, Orit Wasserman wrote: Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) That whole section makes

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Stefan Hajnoczi
On Wed, Sep 14, 2011 at 3:37 PM, Christoph Hellwig h...@lst.de wrote: On Wed, Sep 14, 2011 at 03:24:38PM +0300, Orit Wasserman wrote: Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Christoph Hellwig
On Wed, Sep 14, 2011 at 04:35:50PM +0100, Stefan Hajnoczi wrote: I think the motivation for iSCSI target support in QEMU is exactly what you mentioned - providing shared storage. In migration scenarios it is necessary temporarily make shared storage possible with an image that is on a local

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Stefan Hajnoczi
On Wed, Sep 14, 2011 at 4:40 PM, Christoph Hellwig h...@lst.de wrote: On Wed, Sep 14, 2011 at 04:35:50PM +0100, Stefan Hajnoczi wrote: I think the motivation for iSCSI target support in QEMU is exactly what you mentioned - providing shared storage.  In migration scenarios it is necessary

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Paolo Bonzini
On 09/14/2011 05:51 PM, Stefan Hajnoczi wrote: Why do we need to use the complex iSCSI protocol for that instead of simply using NBD? I think NBD would be fine, especially with a flush command. Indeed: http://permalink.gmane.org/gmane.comp.emulators.qemu/113639 iSCSI is still very useful

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Orit Wasserman
On Wed, 2011-09-14 at 16:51 +0100, Stefan Hajnoczi wrote: On Wed, Sep 14, 2011 at 4:40 PM, Christoph Hellwig h...@lst.de wrote: On Wed, Sep 14, 2011 at 04:35:50PM +0100, Stefan Hajnoczi wrote: I think the motivation for iSCSI target support in QEMU is exactly what you mentioned - providing

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread ronnie sahlberg
On Wed, Sep 14, 2011 at 10:24 PM, Orit Wasserman owass...@redhat.com wrote: Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) Ronnie , are you

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-12 Thread Kevin Wolf
Am 10.09.2011 06:23, schrieb Ronnie Sahlberg: List, Please find a patch that adds built-in iSCSI support to QEMU when built and linked against the multiplatform iscsi initiator library at git://github.com/sahlberg/libiscsi.git All previous comments and suggestions have been addressed

[Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-09 Thread Ronnie Sahlberg
List, Please find a patch that adds built-in iSCSI support to QEMU when built and linked against the multiplatform iscsi initiator library at git://github.com/sahlberg/libiscsi.git All previous comments and suggestions have been addressed in this patch. I and others have done extensive