Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Dan Kenigsberg
On Sun, Dec 09, 2007 at 08:58:34PM +0200, Dan Kenigsberg wrote: > On Sun, Dec 09, 2007 at 07:29:49PM +0100, Andreas Schwab wrote: > > Dan Kenigsberg <[EMAIL PROTECTED]> writes: > > > > > +x86_cpu_def->vendor1 = val[0] + (val[1] << 8) > > > + + (v

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Dan Kenigsberg
On Sun, Dec 09, 2007 at 07:29:49PM +0100, Andreas Schwab wrote: > Dan Kenigsberg <[EMAIL PROTECTED]> writes: > > > +x86_cpu_def->vendor1 = val[0] + (val[1] << 8) > > + + (val[2] << 16) + (val[3] << 24); > > +x86_cpu_def->vendor2 =

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Andreas Schwab
Dan Kenigsberg <[EMAIL PROTECTED]> writes: > +x86_cpu_def->vendor1 = val[0] + (val[1] << 8) > + + (val[2] << 16) + (val[3] << 24); > +x86_cpu_def->vendor2 = val[4] + (val[5] << 8) > + + (val[6]

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Dan Kenigsberg
On Sun, Dec 09, 2007 at 11:36:34AM +, Paul Brook wrote: > > +x86_cpu_def->vendor1 = cpu_to_le32(*(uint32_t *)val); > > +x86_cpu_def->vendor2 = cpu_to_le32(*(uint32_t *)(val + > > 4)); +x86_cpu_def->vendor3 = cpu_to_le32(*(uint32_t *)(val > > Stil

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Paul Brook
> +x86_cpu_def->vendor1 = cpu_to_le32(*(uint32_t *)val); > +x86_cpu_def->vendor2 = cpu_to_le32(*(uint32_t *)(val + > 4)); +x86_cpu_def->vendor3 = cpu_to_le32(*(uint32_t *)(val Still not good enough. val might not be aligned. Paul

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-09 Thread Dan Kenigsberg
On Sun, Dec 09, 2007 at 03:02:44AM +, Thiemo Seufer wrote: > Dan Kenigsberg wrote: > > Having AuthenticAMD hard-coded is nice, but allowing the user to impersonate > > whatever CPU she wants is even nicer. > > > > Also, an English typo (due to me) is corrected. > > > > Dan. > > > > --- a/tar

Re: [Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-12-08 Thread Thiemo Seufer
Dan Kenigsberg wrote: > Having AuthenticAMD hard-coded is nice, but allowing the user to impersonate > whatever CPU she wants is even nicer. > > Also, an English typo (due to me) is corrected. > > Dan. > > --- a/target-i386/helper2.c > +++ b/target-i386/helper2.c > @@ -254,8 +254,17 @@ static in

[Qemu-devel] [PATCH] Allow setting the vendor_id string with x86's -cpu option

2007-11-25 Thread Dan Kenigsberg
Having AuthenticAMD hard-coded is nice, but allowing the user to impersonate whatever CPU she wants is even nicer. Also, an English typo (due to me) is corrected. Dan. --- a/target-i386/helper2.c +++ b/target-i386/helper2.c @@ -254,8 +254,17 @@ static int cpu_x86_find_by_name(x86_def_t *x86_cpu_