Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-25 Thread Mark Wu
Hi guys, Thanks a lot for all your insightful comments. I will post a patch to resolve the O(n2) problem according to Michael's comments soon and rebase the 'success-response' on it. Mark. On 09/25/2013 08:34 AM, Luiz Capitulino wrote: On Tue, 24 Sep 2013 16:07:29 -0500 Michael Roth

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Michael Roth
Quoting Mark Wu (2013-09-22 01:50:54) Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Eric Blake
On 09/24/2013 01:00 PM, Michael Roth wrote: Quoting Mark Wu (2013-09-22 01:50:54) Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command.

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Michael Roth
Quoting Eric Blake (2013-09-24 14:13:08) On 09/24/2013 01:00 PM, Michael Roth wrote: Quoting Mark Wu (2013-09-22 01:50:54) Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Luiz Capitulino
On Tue, 24 Sep 2013 16:07:29 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: +bool qmp_command_has_success_response(const char *name) +{ +QmpCommand *cmd; + +QTAILQ_FOREACH(cmd, qmp_commands, node) { +if (strcmp(cmd-name, name) == 0) { +return

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-23 Thread Luiz Capitulino
On Sun, 22 Sep 2013 14:50:54 +0800 Mark Wu wu...@linux.vnet.ibm.com wrote: Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-23 Thread Eric Blake
On 09/22/2013 12:50 AM, Mark Wu wrote: Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the

[Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-22 Thread Mark Wu
Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexibly. Changes:

[Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-18 Thread Mark Wu
Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexibly.

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-18 Thread Luiz Capitulino
On Wed, 18 Sep 2013 15:23:58 +0800 Mark Wu wu...@linux.vnet.ibm.com wrote: Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-18 Thread Eric Blake
On 09/18/2013 01:23 AM, Mark Wu wrote: Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the