RE: [Qemu-devel] [PATCH] Fix a race condition and non-leaf images growing in VMDK chains.

2007-05-20 Thread Igor Lvovsky
Hi Thiemo, Thank you for comments. You probably right about the child - is_parent renaming, But the parent_open variable (I know, the name is not the best. you can rename it) is not a duplicate of the is_parent. The only one reason for existence of parent_open it's set/reset the

Re: [Qemu-devel] [PATCH] Fix a race condition and non-leaf images growing in VMDK chains.

2007-05-19 Thread Thiemo Seufer
Igor Lvovsky wrote: Hi, The bug was in my last patch. This is a new one. I'll very appreciate any comments. Appended is a variant which gets rid of the confusing child variable which means is_parent, and the duplicate of it (parent_open). There was also an uninitialized variable tmp

Re: [Qemu-devel] [PATCH] Fix a race condition and non-leaf images growing in VMDK chains.

2007-05-19 Thread Thiemo Seufer
Thiemo Seufer wrote: Igor Lvovsky wrote: Hi, The bug was in my last patch. This is a new one. I'll very appreciate any comments. Appended is a variant which gets rid of the confusing child variable which means is_parent, and the duplicate of it (parent_open). There was also

[Qemu-devel] [PATCH] Fix a race condition and non-leaf images growing in VMDK chains.

2007-05-17 Thread Igor Lvovsky
Hi, The bug was in my last patch. This is a new one. I'll very appreciate any comments. Regards, Igor Lvovsky -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Igor Lvovsky Sent: Sunday, May 13, 2007 2:13 PM To:

[Qemu-devel] [PATCH] Fix a race condition and non-leaf images growing in VMDK chains.

2007-05-13 Thread Igor Lvovsky
Hi, In this patch I fixed two issues: 1. A race condition during write operations on snapshots. Now we write the grain of data first and the L2 metadata after. So, the snapshot will stay correct if the VM will be destroyed in the middle of the write. 2. Non-leaf images growing