Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-28 Thread Peter Maydell
On 28 October 2016 at 15:57, Michael Tokarev wrote: > 17.10.2016 07:43, Stefan Weil wrote: >> Am 16.10.2016 um 21:04 schrieb Peter Maydell: >>> On 16 October 2016 at 15:31, Michael Tokarev wrote: 13.10.2016 21:29, Stefan Weil wrote: > scripts/tracetool

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-28 Thread Michael Tokarev
17.10.2016 07:43, Stefan Weil wrote: > Am 16.10.2016 um 21:04 schrieb Peter Maydell: >> On 16 October 2016 at 15:31, Michael Tokarev wrote: >>> 13.10.2016 21:29, Stefan Weil wrote: scripts/tracetool generates a C preprocessor macro from the name of the build directory.

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-16 Thread Stefan Weil
Am 16.10.2016 um 21:04 schrieb Peter Maydell: On 16 October 2016 at 15:31, Michael Tokarev wrote: 13.10.2016 21:29, Stefan Weil wrote: scripts/tracetool generates a C preprocessor macro from the name of the build directory. Any characters which are possible in a directory

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-16 Thread Peter Maydell
On 16 October 2016 at 15:31, Michael Tokarev wrote: > 13.10.2016 21:29, Stefan Weil wrote: >> scripts/tracetool generates a C preprocessor macro from the name of the >> build directory. Any characters which are possible in a directory name >> but not allowed in a macro name must

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-16 Thread Michael Tokarev
13.10.2016 21:29, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail. Applied to -trivial, thank

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-16 Thread Stefan Hajnoczi
On Fri, Oct 14, 2016 at 10:05:18PM +0200, Stefan Weil wrote: > On 10/14/16 12:01, Stefan Hajnoczi wrote: > > dirname should only contain QEMU source tree subdirectory paths (e.g. > > hw/net). How did you get a comma in there? > > > > I tried an out-of-tree build in a directory called 'a,b' but

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-14 Thread Stefan Weil
On 10/14/16 12:01, Stefan Hajnoczi wrote: dirname should only contain QEMU source tree subdirectory paths (e.g. hw/net). How did you get a comma in there? I tried an out-of-tree build in a directory called 'a,b' but it doesn't trigger the issue. I'd like to understand how to reproduce the

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-14 Thread Paolo Bonzini
On 14/10/2016 11:53, Stefan Hajnoczi wrote: > > Why does it need to care about the build directory name at all? > > Ideally builds should be entirely deterministically reproducible > > whatever the path to the source or build directory names is... > > It's trying to construct the relative path

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-14 Thread Stefan Hajnoczi
On Thu, Oct 13, 2016 at 08:29:30PM +0200, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail. > >

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-14 Thread Stefan Hajnoczi
On Thu, Oct 13, 2016 at 07:36:07PM +0100, Peter Maydell wrote: > On 13 October 2016 at 19:29, Stefan Weil wrote: > > scripts/tracetool generates a C preprocessor macro from the name of the > > build directory. Any characters which are possible in a directory name > > but not

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-13 Thread Peter Maydell
On 13 October 2016 at 19:29, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro from the name of the > build directory. Any characters which are possible in a directory name > but not allowed in a macro name must be substituted, otherwise builds > will fail.

[Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-13 Thread Stefan Weil
scripts/tracetool generates a C preprocessor macro from the name of the build directory. Any characters which are possible in a directory name but not allowed in a macro name must be substituted, otherwise builds will fail. Signed-off-by: Stefan Weil --- I had problems with a