Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction (followup)

On Sun, Jun 5, 2011 at 7:49 PM, Alexandre Raymond wrote: > Hi Blue, > > This patch indeed depends on http://patchwork.ozlabs.org/patch/98325/. > > Since it had already been applied by Andreas to the trivial tree, I > didn't think it was necessary to resend it in the followup. > > If you prefer, I

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction (followup)

Hi Blue, This patch indeed depends on http://patchwork.ozlabs.org/patch/98325/. Since it had already been applied by Andreas to the trivial tree, I didn't think it was necessary to resend it in the followup. If you prefer, I can resend both in the same series. Alexandre On Sun, Jun 5, 2011 at

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction (followup)

On Fri, Jun 3, 2011 at 6:26 AM, Alexandre Raymond wrote: > This patch removes all references to signal.h when qemu-common.h is included > as they become redundant. This breaks the build. Maybe it depends on some previous patch? If so, it would be nice to submit the patches as a series so that the

[Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction (followup)

This patch removes all references to signal.h when qemu-common.h is included as they become redundant. Signed-off-by: Alexandre Raymond --- audio/audio_pt_int.c |2 -- audio/sdlaudio.c |1 - block/raw-posix.c |2 -- bsd-user/syscall.c|1 - darwin-user/signal.c |

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

On Thu, Jun 2, 2011 at 11:55 PM, Alexandre Raymond wrote: > Should I send a follow-up patch to remove signal.h wherever > qemu-common.h is already included? Yes, please. I didn't know that qemu-common.h pulls in system headers so users don't need to, I always figured .c files should include what

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

Thanks Stefan, Should I send a follow-up patch to remove signal.h wherever qemu-common.h is already included? Alexandre On Thu, Jun 2, 2011 at 6:44 PM, Stefan Hajnoczi wrote: > On Thu, Jun 2, 2011 at 3:21 AM, Alexandre Raymond wrote: >> Fix the following warning by including signal.h directly

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

On Thu, Jun 2, 2011 at 3:21 AM, Alexandre Raymond wrote: > Fix the following warning by including signal.h directly in qemu-common.h > 8< > iohandler.c: In function ‘qemu_init_child_watch’: > iohandler.c:172: warning: implicit declaration of function ‘sigaction’ > iohandler.c:172: warning:

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

On Thu, Jun 2, 2011 at 6:13 AM, Andreas Färber wrote: > Am 02.06.2011 um 04:21 schrieb Alexandre Raymond: > >> Fix the following warning by including signal.h directly in qemu-common.h >> 8< >> iohandler.c: In function ‘qemu_init_child_watch’: >> iohandler.c:172: warning: implicit declarat

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

Am 02.06.2011 um 04:21 schrieb Alexandre Raymond: Fix the following warning by including signal.h directly in qemu- common.h 8< iohandler.c: In function ‘qemu_init_child_watch’: iohandler.c:172: warning: implicit declaration of function ‘sigaction’ iohandler.c:172: warning: nested exter

[Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

Fix the following warning by including signal.h directly in qemu-common.h 8< iohandler.c: In function ‘qemu_init_child_watch’: iohandler.c:172: warning: implicit declaration of function ‘sigaction’ iohandler.c:172: warning: nested extern declaration of ‘sigaction’ 8< Signed-off-by: