Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-07-19 Thread Jan Kiszka
On 2012-07-18 22:42, Ma, Stephen B. wrote: Sorry for taking so long to reply. I am new to this. Should this patch be committed or just dropped This bug was fixed by 266ca11a0433643a3cc3146a9837d9f2b0bfbe3b in the meantime. Jan -Original Message- From: Jan Kiszka

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-07-18 Thread Ma, Stephen B.
Sorry for taking so long to reply. I am new to this. Should this patch be committed or just dropped -Original Message- From: Jan Kiszka [mailto:jan.kis...@web.de] Sent: Sunday, June 17, 2012 11:25 PM To: Anthony Liguori Cc: Michael S. Tsirkin; 'qemu-devel@nongnu.org'; Ma, Stephen B.

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-18 Thread Jan Kiszka
On 2012-06-17 16:28, Anthony Liguori wrote: On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote: On Sun, Jun 17, 2012 at 06:26:33AM +, Ma, Stephen B. wrote: Michael, Thanks for the review. I added the unparent to the qdev_free. --- hw/qdev.c |1 + 1 files changed, 1

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-17 Thread Ma, Stephen B.
Michael, Thanks for the review. I added the unparent to the qdev_free. --- hw/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d2dc28b..ed1328d 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -264,6 +264,7 @@ void

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-17 Thread Michael S. Tsirkin
On Sun, Jun 17, 2012 at 06:26:33AM +, Ma, Stephen B. wrote: Michael, Thanks for the review. I added the unparent to the qdev_free. --- hw/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d2dc28b..ed1328d 100644 ---

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-17 Thread Anthony Liguori
On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote: On Sun, Jun 17, 2012 at 06:26:33AM +, Ma, Stephen B. wrote: Michael, Thanks for the review. I added the unparent to the qdev_free. --- hw/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c

Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-12 Thread Michael S. Tsirkin
On Tue, Jun 12, 2012 at 04:31:20AM +, Ma, Stephen B. wrote: diff --git a/hw/qdev.c b/hw/qdev.c index 6a8f6bd..d2dc28b 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -139,7 +139,7 @@ DeviceState *qdev_try_create(BusState *bus, const char *type) /* Initialize a device. Device properties

[Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-12 Thread Ma, Stephen B.
Title: Fix for qemu crash on assertion error when adding PCI passthru device. Description: On a kernel 3.4.0+ without having interrupt remapping enabled, starting a VM having a PCI passthrough device fails. ON q qemu-kvm built with --enable-debug, qemu aborts. Qemu-kvm is executed via virsh.