Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-23 Thread Avi Kivity
On 03/22/2011 03:26 PM, Anthony Liguori wrote: Here's how I propose we tackle this. This patch adds a -dump-savevm option that takes a version. It spits out all of the fields we save for a particular version (well, not really, but it should). We also can add type information. The idea is

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-23 Thread Yoshiaki Tamura
2011/3/23 Avi Kivity a...@redhat.com: On 03/22/2011 03:26 PM, Anthony Liguori wrote: Here's how I propose we tackle this.  This patch adds a -dump-savevm option that takes a version.  It spits out all of the fields we save for a particular version (well, not really, but it should).  We also

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-23 Thread Anthony Liguori
On 03/23/2011 04:10 AM, Avi Kivity wrote: On 03/22/2011 03:26 PM, Anthony Liguori wrote: Here's how I propose we tackle this. This patch adds a -dump-savevm option that takes a version. It spits out all of the fields we save for a particular version (well, not really, but it should). We

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply,

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half

Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 07:50 AM, Stefan Berger wrote: On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM,

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Jan Kiszka
On 2011-03-22 12:56, Stefan Berger wrote: On 03/22/2011 07:50 AM, Stefan Berger wrote: On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM,

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest did catch the uint8 varray thing. c995b4 isn't yet in qemu-kvm.git, so it

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Jan Kiszka
On 2011-03-22 13:21, Avi Kivity wrote: On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest did catch the uint8 varray thing.

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 02:30 PM, Jan Kiszka wrote: On 2011-03-22 13:21, Avi Kivity wrote: On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version?

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Anthony Liguori
On 03/22/2011 07:00 AM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest is too late and also not nearly rigorous enough for what you're trying to catch.

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-21 Thread Stefan Berger
On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply, without this migration using hpet is broken. (only current user). I have just been bisecting the

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-21 Thread Anthony Liguori
On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply, without this migration using hpet is broken. (only

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-18 Thread Yoshiaki Tamura
2011/3/15 Juan Quintela quint...@redhat.com: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix.  It forgots the save state fix for UINT8 indexes. Anthony, please apply, without this migration using hpet is broken. (only current user). Signed-off-by: Juan

[Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-15 Thread Juan Quintela
commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply, without this migration using hpet is broken. (only current user). Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c |2 ++ 1