Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-05-04 Thread ronnie sahlberg
On Fri, May 4, 2012 at 6:06 PM, Paolo Bonzini wrote: > Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: >> +    itask->bs->total_sectors    = rc16->returned_lba * >> +                               rc16->block_length / BDRV_SECTOR_SIZE ; > > Ronnie, does this need to be "(rc16->returned_lba + 1) *

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-05-04 Thread Paolo Bonzini
Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: > +itask->bs->total_sectors= rc16->returned_lba * > + rc16->block_length / BDRV_SECTOR_SIZE ; Ronnie, does this need to be "(rc16->returned_lba + 1) * ..."? READ CAPACITY returns the highest valid LBA, not the

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 6:05 PM, Paolo Bonzini wrote: > Il 24/04/2012 10:02, ronnie sahlberg ha scritto: >> So ignore this patch for now. I will redo UNMAP in the patch to >> instead use the generic scsi function inside libiscsi. >> >> That will serve the purpose to verify that the public API in l

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 10:02, ronnie sahlberg ha scritto: > So ignore this patch for now. I will redo UNMAP in the patch to > instead use the generic scsi function inside libiscsi. > > That will serve the purpose to verify that the public API in libiscsi > is sufficient for accessing the generic transport

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread Kevin Wolf
Am 24.04.2012 08:46, schrieb Paolo Bonzini: > Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: >> Update the configure test for libiscsi support to detect version 1.3 or >> later. >> Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP >> commands. >> >> Update the iscsi block la

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 4:46 PM, Paolo Bonzini wrote: > Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: >> Update the configure test for libiscsi support to detect version 1.3 or >> later. >> Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP >> commands. >> >> Update the isc

Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-23 Thread Paolo Bonzini
Il 24/04/2012 08:29, Ronnie Sahlberg ha scritto: > Update the configure test for libiscsi support to detect version 1.3 or later. > Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP > commands. > > Update the iscsi block layer to use READCAPACITY16 to detect the size of the >

[Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

2012-04-23 Thread Ronnie Sahlberg
Update the configure test for libiscsi support to detect version 1.3 or later. Version 1.3 of libiscsi provides both READCAPACITY16 as well as UNMAP commands. Update the iscsi block layer to use READCAPACITY16 to detect the size of the LUN instead of READCAPACITY10. This allows support for LUNs l