Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-14 Thread Michal Novotny
On 07/13/2011 04:11 PM, Paolo Bonzini wrote: On 07/13/2011 03:06 PM, Michal Novotny wrote: +uint64_t time_get(const char *name, int stage); +void time_set(const char *name, int stage, uint64_t tv); +void time_add(const char *name, int stage, uint64_t tv); +void time_add2(const char *name, int

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-14 Thread Paolo Bonzini
On 07/14/2011 10:45 AM, Michal Novotny wrote: Please inline all these instead of adding new functions. Do you mean to implement as macros? I'm trying since yesterday and it's not that simple because the variable has to be accessible from 3 files - arch_init.c, savevm.c and migration.c. So I

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-14 Thread Michal Novotny
On 07/14/2011 11:44 AM, Paolo Bonzini wrote: On 07/14/2011 10:45 AM, Michal Novotny wrote: Please inline all these instead of adding new functions. Do you mean to implement as macros? I'm trying since yesterday and it's not that simple because the variable has to be accessible from 3 files -

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-14 Thread Michal Novotny
On 07/14/2011 12:15 PM, Paolo Bonzini wrote: On 07/14/2011 12:05 PM, Michal Novotny wrote: What do you mean by removing migration.c from the list? Do you mean doing no modifications to this file? No usage of the time variables in migration.c. it's about milliseconds It's noise anyway. The

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-14 Thread Paolo Bonzini
On 07/14/2011 12:05 PM, Michal Novotny wrote: What do you mean by removing migration.c from the list? Do you mean doing no modifications to this file? No usage of the time variables in migration.c. it's about milliseconds It's noise anyway. The arch_init.c to include savevm-related code

[Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-13 Thread Michal Novotny
Hi, this is the implementation of the info migrate-times command I did to get the times for the migration to get times for each migration stage. Based on the fact migration itself is just the vmsave on the source host and vmload on destination host this function can be also useful to get the save

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-13 Thread Paolo Bonzini
On 07/13/2011 03:06 PM, Michal Novotny wrote: +uint64_t time_get(const char *name, int stage); +void time_set(const char *name, int stage, uint64_t tv); +void time_add(const char *name, int stage, uint64_t tv); +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2);