Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-11 Thread Paul Brook
> Note that I *only* object to case 2 (derive bus name from parent > device's ID). Case 3 (derive bus name from bus type) is fine with me. > > > Using a single counter for all busses is also wrong. The order of bus > > creation is a device implementation detail, under no circumstances > > should

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-11 Thread Markus Armbruster
Paul Brook writes: >> Paul Brook writes: >> >> The system emulators for each arch are using inconsistent >> >> naming for the default PCI bus "pci" vs "pci.0". Since it >> >> is conceivable we'll have multiple PCI buses in the future >> >> standardize on "pci.0" for all architectures. This ensur

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-03 Thread Andreas Färber
Am 02.06.2010 um 16:12 schrieb Daniel P. Berrange: On Fri, May 28, 2010 at 08:39:53PM +0100, Paul Brook wrote: The system emulators for each arch are using inconsistent naming for the default PCI bus "pci" vs "pci.0". Since it is conceivable we'll have multiple PCI buses in the future standardi

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-02 Thread Paul Brook
>Hi, > > > I disagree. Anything that depends on device creation order is > > fundamentally broken. If you want to create globally unique > > user-friendly tags for devices or busses then that is a completely > > different problem, and should be done via explicit aliases. > > For anything cre

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-02 Thread Gerd Hoffmann
Hi, I disagree. Anything that depends on device creation order is fundamentally broken. If you want to create globally unique user-friendly tags for devices or busses then that is a completely different problem, and should be done via explicit aliases. For anything created via -device the i

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-02 Thread Paul Brook
> Paul Brook writes: > >> The system emulators for each arch are using inconsistent > >> naming for the default PCI bus "pci" vs "pci.0". Since it > >> is conceivable we'll have multiple PCI buses in the future > >> standardize on "pci.0" for all architectures. This ensures > >> mgmt apps can rely

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-02 Thread Paul Brook
> The problem is that the ID names of default devices in machines are ABI > sensitive. Management apps need to know what the ID of these default > devices are. The x86 machines have already used 'pci.0' as their name > in the previous 0.12 release and libvirt is using this naming. We later > discov

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-06-02 Thread Daniel P. Berrange
On Fri, May 28, 2010 at 08:39:53PM +0100, Paul Brook wrote: > > The system emulators for each arch are using inconsistent > > naming for the default PCI bus "pci" vs "pci.0". Since it > > is conceivable we'll have multiple PCI buses in the future > > standardize on "pci.0" for all architectures. Th

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-29 Thread Markus Armbruster
Paul Brook writes: >> The system emulators for each arch are using inconsistent >> naming for the default PCI bus "pci" vs "pci.0". Since it >> is conceivable we'll have multiple PCI buses in the future >> standardize on "pci.0" for all architectures. This ensures >> mgmt apps can rely on a name

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-28 Thread Paul Brook
> The system emulators for each arch are using inconsistent > naming for the default PCI bus "pci" vs "pci.0". Since it > is conceivable we'll have multiple PCI buses in the future > standardize on "pci.0" for all architectures. This ensures > mgmt apps can rely on a name when assigning PCI devices

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-20 Thread Daniel P. Berrange
On Wed, May 19, 2010 at 10:19:06PM +0300, Blue Swirl wrote: > On 5/19/10, Daniel P. Berrange wrote: > > The system emulators for each arch are using inconsistent > > naming for the default PCI bus "pci" vs "pci.0". Since it > > is conceivable we'll have multiple PCI buses in the future > > stan

[Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures (v2)

2010-05-20 Thread Daniel P. Berrange
The system emulators for each arch are using inconsistent naming for the default PCI bus "pci" vs "pci.0". Since it is conceivable we'll have multiple PCI buses in the future standardize on "pci.0" for all architectures. This ensures mgmt apps can rely on a name when assigning PCI devices an addres

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-19 Thread Blue Swirl
On 5/19/10, Daniel P. Berrange wrote: > The system emulators for each arch are using inconsistent > naming for the default PCI bus "pci" vs "pci.0". Since it > is conceivable we'll have multiple PCI buses in the future > standardize on "pci.0" for all architectures. This ensures > mgmt apps ca

[Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-19 Thread Daniel P. Berrange
The system emulators for each arch are using inconsistent naming for the default PCI bus "pci" vs "pci.0". Since it is conceivable we'll have multiple PCI buses in the future standardize on "pci.0" for all architectures. This ensures mgmt apps can rely on a name when assigning PCI devices an addres