Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-09-12 Thread Thiemo Seufer
Ulrich Hecht wrote: [snip] +#ifdef __s390__ +retaddr = (void*)((unsigned long)retaddr 0x7fffUL); +#endif All of those look weird. Is this a null-extension vs. sign-extension issue? S/390 has a 31 (thirty-one) bit address space; the MSB of the PSW is not part of the

Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-08-01 Thread Ulrich Hecht
On Wednesday 01 August 2007 01:59, Thiemo Seufer wrote: -AIOLIBS=-lrt +AIOLIBS=-lrt -lpthread Why is this needed? Linux toolchains should add -lpthread implicitly. Our SLES9 toolchain seems not to. It's a near-cosmetic change. +#ifdef __s390__ +retaddr = (void*)((unsigned

Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-07-31 Thread Thiemo Seufer
Ulrich Hecht wrote: On Monday 30 July 2007 13:49, Ulrich Hecht wrote: S/390 host support has been broken for a long time (since 0.4.2 or something like that). I finally got around to fix it, adding disassembly support on the way. And here's an even better patch that also fixes non-i386

Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-07-31 Thread Paul Brook
void op_cfc1 (void) { +#ifdef __s390__ +if(!T1) +T0 = (int32_t)env-fcr0; I guess this breaks when you _breathe_ at the compiler. Inventing switch-table support in dyngen would be preferable (if possible...). Actually, I'm surprised this doesn't break on other hosts.

Re: [Qemu-devel] [PATCH] S/390 host fixed

2007-07-30 Thread Sunil Amitkumar Janki
Ulrich Hecht wrote: Hi! S/390 host support has been broken for a long time (since 0.4.2 or something like that). I finally got around to fix it, adding disassembly support on the way. CU Uli Do you or anyone else have any plans to add S/390 target support? Or is there some other