Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Andreas Färber
Am 11.01.2016 um 18:37 schrieb Markus Armbruster: > Paolo Bonzini writes: >> On 07/01/2016 10:53, Cao jin wrote: >>> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: These functions are called in the data path; changes to use SCSI_BUS() should come wi

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Peter Maydell
On 11 January 2016 at 17:37, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 07/01/2016 10:53, Cao jin wrote: >>> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: These functions are called in the data path; changes to use SCSI_BUS() should

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/01/2016 10:53, Cao jin wrote: >> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: >>> On 06/01/2016 14:43, Cao jin wrote: >>> These functions are called in the data path; changes to use SCSI_BUS() >>> should come with performance data proving that it doesn't slow down I/

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-07 Thread Paolo Bonzini
On 07/01/2016 10:53, Cao jin wrote: > On 01/07/2016 05:38 PM, Paolo Bonzini wrote: >> On 06/01/2016 14:43, Cao jin wrote: >> These functions are called in the data path; changes to use SCSI_BUS() >> should come with performance data proving that it doesn't slow down I/O. >> > > I see. I am not fam

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-07 Thread Cao jin
On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: [...] These functions are called in the data path; changes to use SCSI_BUS() should come with performance data proving that it doesn't slow down I/O. Paolo I see. I am not familiar with the procedure of sc

[Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-06 Thread Cao jin
Signed-off-by: Cao jin --- hw/scsi/scsi-bus.c | 16 include/hw/scsi/scsi.h | 5 - 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index fea0257..1667e01 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -5