Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-25 Thread Peter Maydell
Ping? There doesn't seem to have been any decision about whether changing the -help output was OK or not. Patchwork url: http://patchwork.ozlabs.org/patch/169798/ -- PMM On 9 July 2012 12:52, Peter Maydell peter.mayd...@linaro.org wrote: For command line options which permit '?' meaning

[Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. Update the documentation to use 'help' rather than '?', since '?' is a shell metacharacter and thus prone to fail

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 05:52 AM, Peter Maydell wrote: For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. Update the documentation to use 'help' rather than '?', since '?' is a

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:07, Eric Blake ebl...@redhat.com wrote: That is, we are filtering based on the explicit presence of a literal '?' in the help output to determine whether we can further filter based on '-device device,?' queries without confusing qemu or libvirt; changing the 'help' output

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Eric Blake
On 07/09/2012 06:10 AM, Peter Maydell wrote: On 9 July 2012 13:07, Eric Blake ebl...@redhat.com wrote: That is, we are filtering based on the explicit presence of a literal '?' in the help output to determine whether we can further filter based on '-device device,?' queries without confusing

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Daniel P. Berrange
On Mon, Jul 09, 2012 at 06:07:48AM -0600, Eric Blake wrote: On 07/09/2012 05:52 AM, Peter Maydell wrote: For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function.

Re: [Qemu-devel] [PATCH] Support 'help' as a synonym for '?' in command line options

2012-07-09 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 07/09/2012 06:10 AM, Peter Maydell wrote: On 9 July 2012 13:07, Eric Blake ebl...@redhat.com wrote: That is, we are filtering based on the explicit presence of a literal '?' in the help output to determine whether we can further filter based on