Re: [Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-05 Thread Richard Yang
On Sat, Feb 04, 2012 at 10:22:09AM +, Blue Swirl wrote: On Tue, Jan 31, 2012 at 06:56, Wei Yang weiy...@linux.vnet.ibm.com wrote: Tested on i386 platform. Signed-off-by: Wei Yangweiy...@linux.vnet.ibm.com Nack. Definitions should reside in files where they are used, only in header files

Re: [Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-04 Thread Blue Swirl
On Tue, Jan 31, 2012 at 06:56, Wei Yang weiy...@linux.vnet.ibm.com wrote: Tested on i386 platform. Signed-off-by: Wei Yangweiy...@linux.vnet.ibm.com Nack. Definitions should reside in files where they are used, only in header files when they are used by multiple sources. ---  qemu-timer.c |

[Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-02 Thread Wei Yang
Tested on i386 platform. Signed-off-by: Wei Yangweiy...@linux.vnet.ibm.com --- qemu-timer.c | 40 qemu-timer.h | 41 + 2 files changed, 41 insertions(+), 40 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c