Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-02 Thread Kevin Wolf
Am 01.03.2012 17:52, schrieb Paolo Bonzini: But you can even keep from your first patch the drive-reopen command and not make it atomic, that shouldn't be a problem. I'm not sure whether it makes sense for a separate drive-reopen or whether to just add this to blockdev-transaction (or even

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-02 Thread Anthony Liguori
On 03/01/2012 09:13 AM, Federico Simoncelli wrote: Signed-off-by: Federico Simoncellifsimo...@redhat.com This is a good example of the introspection comment. libvirt could never figure out this was available unless this came in with the original command. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-02 Thread Paolo Bonzini
Il 02/03/2012 14:00, Kevin Wolf ha scritto: Am 01.03.2012 17:52, schrieb Paolo Bonzini: But you can even keep from your first patch the drive-reopen command and not make it atomic, that shouldn't be a problem. I'm not sure whether it makes sense for a separate drive-reopen or whether to just

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-02 Thread Kevin Wolf
Am 02.03.2012 14:25, schrieb Paolo Bonzini: Il 02/03/2012 14:00, Kevin Wolf ha scritto: Am 01.03.2012 17:52, schrieb Paolo Bonzini: But you can even keep from your first patch the drive-reopen command and not make it atomic, that shouldn't be a problem. I'm not sure whether it makes sense

[Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-01 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- blockdev.c |8 qapi-schema.json | 12 qmp-commands.hx |6 +- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 56da5c9..36fe07c 100644 --- a/blockdev.c

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-01 Thread Paolo Bonzini
Il 01/03/2012 16:13, Federico Simoncelli ha scritto: Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- blockdev.c |8 qapi-schema.json | 12 qmp-commands.hx |6 +- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-01 Thread Eric Blake
On 03/01/2012 08:36 AM, Paolo Bonzini wrote: Il 01/03/2012 16:13, Federico Simoncelli ha scritto: Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- blockdev.c |8 qapi-schema.json | 12 qmp-commands.hx |6 +- 3 files changed, 25

Re: [Qemu-devel] [PATCH] add reopen to blockdev-transaction

2012-03-01 Thread Paolo Bonzini
Do we need more flexibility in what is being reopened? I see several possibilities. In the examples below, I'm using '*' for any file that qemu has an open fd for, and [] to show the contents of a backing file field within that file (which can be relative or absolute). 1. post-copy,