Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM
On 5/1/19 8:18 AM, Joel Stanley wrote:
> We currently use Qemu's default of 128MB. As we know how much ram each
> machine ships with, make it easier on users by setting a default.
>
> It can still be overridden with -m on the command line.
>
> Signed-off-by: Joel Stanley
> ---
> hw/arm/aspeed.c
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM
On 4/30/19 11:18 PM, Joel Stanley wrote:
> mc->no_parallel = 1;
> +if (board->ram)
> +mc->default_ram_size = board->ram;
In addition to the braces, for which patchew will have sent you nag mail...
> +.ram = 256 << 20,
In there are some defines to make this more re
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM
On Wed, 1 May 2019, at 15:48, Joel Stanley wrote:
> We currently use Qemu's default of 128MB. As we know how much ram each
> machine ships with, make it easier on users by setting a default.
>
> It can still be overridden with -m on the command line.
>
> Signed-off-by: Joel Stanley
Reviewed-
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM
We currently use Qemu's default of 128MB. As we know how much ram each
machine ships with, make it easier on users by setting a default.
It can still be overridden with -m on the command line.
Signed-off-by: Joel Stanley
---
hw/arm/aspeed.c | 6 ++
include/hw/arm/aspeed.h | 1 +
2 f
