[Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Liviu Ionescu
For standalone emulation, the image must be specified via -kernel, but when using QEMU as a GDB server, the presence of -kernel is no longer mandatory, since the image can be loaded by the GDB client. Signed-off-by: Liviu Ionescu i...@livius.net --- hw/arm/armv7m.c | 3 ++-

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Peter Maydell
On 20 November 2014 12:05, Liviu Ionescu i...@livius.net wrote: For standalone emulation, the image must be specified via -kernel, but when using QEMU as a GDB server, the presence of -kernel is no longer mandatory, since the image can be loaded by the GDB client. I think the correct fix for

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Liviu Ionescu
On 20 Nov 2014, at 14:29, Peter Maydell peter.mayd...@linaro.org wrote: -if (!kernel_filename !qtest_enabled()) { +if (!kernel_filename !qtest_enabled() !with_gdb) { fprintf(stderr, Guest image must be specified (using -kernel)\n); exit(1); } just delete

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Peter Maydell
On 20 November 2014 12:34, Liviu Ionescu i...@livius.net wrote: On 20 Nov 2014, at 14:29, Peter Maydell peter.mayd...@linaro.org wrote: -if (!kernel_filename !qtest_enabled()) { +if (!kernel_filename !qtest_enabled() !with_gdb) { fprintf(stderr, Guest image must be

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Liviu Ionescu
On 20 Nov 2014, at 14:50, Peter Maydell peter.mayd...@linaro.org wrote: Same thing as if you start a hardware board with nothing loaded into the flash. (Probably this means go into an infinite loop of taking exceptions.) hmmm... and you consider this behaviour to meet the user-friendly

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Peter Maydell
On 20 November 2014 13:09, Liviu Ionescu i...@livius.net wrote: On 20 Nov 2014, at 14:50, Peter Maydell peter.mayd...@linaro.org wrote: Same thing as if you start a hardware board with nothing loaded into the flash. (Probably this means go into an infinite loop of taking exceptions.)

Re: [Qemu-devel] [PATCH] armv7m: optional -kernel if -gdb present

2014-11-20 Thread Liviu Ionescu
On 20 Nov 2014, at 15:20, Peter Maydell peter.mayd...@linaro.org wrote: ... However the solutions you're proposing are often specific to M-profile ARM, ok, I'll keep this local to my branch. what about the previous patch, is it acceptable? regards, Liviu