Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-06-14 Thread Fam Zheng
On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc:

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-06-14 Thread Fam Zheng
On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc:

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-06-14 Thread Max Reitz
On 18.05.2016 07:53, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. > > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread Fam Zheng
On Wed, 05/18 08:25, Eric Blake wrote: > On 05/17/2016 11:53 PM, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > s/quiting/quitting/ > > > > > A simple reproducer is running blockdev-backup from null-co:// to > >

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread Eric Blake
On 05/17/2016 11:53 PM, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. s/quiting/quitting/ > > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. Worth a qemu-iotests addition? > > Cc:

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread John Snow
On 05/18/2016 01:53 AM, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. > Tch, mea culpa. > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. > > Cc: qemu-sta...@nongnu.org > Signed-off-by:

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-18 Thread Jeff Cody
On Wed, May 18, 2016 at 01:53:27PM +0800, Fam Zheng wrote: > Otherwise the job is orphaned and block_job_cancel_sync in > bdrv_close_all() when quiting will hang. > > A simple reproducer is running blockdev-backup from null-co:// to > null-co://. > > Cc: qemu-sta...@nongnu.org > Signed-off-by:

[Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size

2016-05-17 Thread Fam Zheng
Otherwise the job is orphaned and block_job_cancel_sync in bdrv_close_all() when quiting will hang. A simple reproducer is running blockdev-backup from null-co:// to null-co://. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng --- block/backup.c | 34