Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 02:46:24PM -0500, Jeff Cody wrote: There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible.

Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-13 Thread Kevin Wolf
Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible. This patch

[Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-12 Thread Jeff Cody
There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible. This patch replaces those instances with error_setg_errno(), so that

Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-12 Thread Eric Blake
On 02/12/2014 12:46 PM, Jeff Cody wrote: There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible. This patch replaces

Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-12 Thread Fam Zheng
On Wed, 02/12 14:46, Jeff Cody wrote: There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible. This patch replaces