Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-24 Thread Kevin Wolf
Am 23.03.2016 um 21:11 hat Max Reitz geschrieben: > On 18.03.2016 11:31, Kevin Wolf wrote: > > The call in hmp_drive_del() is dead code because blk_remove_bs() is > > called a few lines above. > > Ah, so that's why I didn't have it in v3. Thanks for solving that > mystery for me. :-) I could have

Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-23 Thread Max Reitz
On 18.03.2016 11:31, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. Ah, so that's why I didn't have it in v3. Thanks for solving that mystery for me. :-) > The only other remaining user is > bdrv_delete

Re: [Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-21 Thread Eric Blake
On 03/18/2016 04:31 AM, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. The only other remaining user is > bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the > named nodes list. This path inlines the list entry

[Qemu-devel] [PATCH] block: Remove bdrv_make_anon()

2016-03-19 Thread Kevin Wolf
The call in hmp_drive_del() is dead code because blk_remove_bs() is called a few lines above. The only other remaining user is bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the named nodes list. This path inlines the list entry removal into bdrv_delete() and removes bdrv_make_