Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-13 Thread Stefan Hajnoczi
On Tue, Nov 13, 2012 at 01:27:57PM +0100, Kevin Wolf wrote: > Am 10.11.2012 10:59, schrieb Gerhard Wiesinger: > > On 10.11.2012 09:55, Paolo Bonzini wrote: > >> Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: > > 2.) Added debug code to block.c and to block/vmdk.c to verify > > correctne

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-13 Thread Kevin Wolf
Am 10.11.2012 10:59, schrieb Gerhard Wiesinger: > On 10.11.2012 09:55, Paolo Bonzini wrote: >> Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: > 2.) Added debug code to block.c and to block/vmdk.c to verify > correctness Same here. Also, please use the tracing infrastructure---a lo

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-10 Thread Gerhard Wiesinger
On 10.11.2012 09:55, Paolo Bonzini wrote: Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: 2.) Added debug code to block.c and to block/vmdk.c to verify correctness Same here. Also, please use the tracing infrastructure---a lot of the debug messages you're adding, though not all, are in fact

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-10 Thread Paolo Bonzini
Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: >>> 2.) Added debug code to block.c and to block/vmdk.c to verify >>> correctness >> Same here. Also, please use the tracing infrastructure---a lot of the >> debug >> messages you're adding, though not all, are in fact already available >> (not >>

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-10 Thread Gerhard Wiesinger
On 09.11.2012 09:26, Paolo Bonzini wrote: Il 08/11/2012 20:05, Gerhard Wiesinger ha scritto: Fixed a MAJOR BUG in VMDK files on file boundaries on reads and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! Triggered for example with the following VMDK file (partly listed): # Extent d

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-09 Thread Paolo Bonzini
Il 08/11/2012 20:05, Gerhard Wiesinger ha scritto: > Fixed a MAJOR BUG in VMDK files on file boundaries on reads > and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! > > Triggered for example with the following VMDK file (partly listed): > # Extent description > RW 4193792 FLAT "XP-W1

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-08 Thread Lei Li
On 11/09/2012 01:12 PM, Fam Zheng wrote: Yes, I can confirm the presence of this bug and this is a valid fix. May I ask where is this kind of vmdk from? Because regularly we see extents in identical size. I guess the regularly extents you see are SPARSE extent in identical size. This is the FL

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-08 Thread Gerhard Wiesinger
Hello, It was created with VMWare Server 2.0.x or maybe even with 1.x. under Linux. Ciao, Gerhard On 09.11.2012 06:12, Fam Zheng wrote: Yes, I can confirm the presence of this bug and this is a valid fix. May I ask where is this kind of vmdk from? Because regularly we see extents in identical

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-08 Thread Fam Zheng
Yes, I can confirm the presence of this bug and this is a valid fix. May I ask where is this kind of vmdk from? Because regularly we see extents in identical size. --- Best regards! Fam Zheng On Fri, Nov 9, 2012 at 3:05 AM, Gerhard Wiesinger wrote: > Fixed a MAJOR BUG in VMDK files on file bou

[Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-08 Thread Gerhard Wiesinger
Fixed a MAJOR BUG in VMDK files on file boundaries on reads and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! Triggered for example with the following VMDK file (partly listed): # Extent description RW 4193792 FLAT "XP-W1-f001.vmdk" 0 RW 2097664 FLAT "XP-W1-f002.vmdk" 0 RW 4193792 F