Re: [Qemu-devel] [PATCH] blockdev: fix missed target unref for drive-backup

2019-05-13 Thread John Snow
On 5/13/19 7:13 AM, Kevin Wolf wrote: > Am 10.05.2019 um 23:52 hat John Snow geschrieben: >> If the bitmap can't be used for whatever reason, we skip putting down >> the reference. Fix that. >> >> In practice, this means that if you attempt to gracefully exit QEMU >> after a backup command being

Re: [Qemu-devel] [PATCH] blockdev: fix missed target unref for drive-backup

2019-05-13 Thread Kevin Wolf
Am 10.05.2019 um 23:52 hat John Snow geschrieben: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell

[Qemu-devel] [PATCH] blockdev: fix missed target unref for drive-backup

2019-05-10 Thread John Snow
If the bitmap can't be used for whatever reason, we skip putting down the reference. Fix that. In practice, this means that if you attempt to gracefully exit QEMU after a backup command being rejected, bdrv_close_all will fail and tell you some unpleasant things via assert(). Reported-by: aihua l