Re: [Qemu-devel] [PATCH] chardev: fix incorrect unref of source

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 06:20, Peter Xu wrote: > glib reported error when pty chardev used: > > $ ./qemu-system-x86_64 -chardev pty,id=foo -device isa-serial,chardev=foo > qemu-system-x86_64: -chardev pty,id=foo: char device redirected to /dev/pts/2 > (label foo) > (qemu-system-x86_64:27885):

[Qemu-devel] [PATCH] chardev: fix incorrect unref of source

2018-01-17 Thread Peter Xu
glib reported error when pty chardev used: $ ./qemu-system-x86_64 -chardev pty,id=foo -device isa-serial,chardev=foo qemu-system-x86_64: -chardev pty,id=foo: char device redirected to /dev/pts/2 (label foo) (qemu-system-x86_64:27885): GLib-CRITICAL **: g_source_unref: assertion 'source != NULL'