Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-16 Thread Antonio Ospite
Hi, thanks for the comments. On Fri, 15 Mar 2019 13:48:25 -0500 Eric Blake wrote: > On 3/15/19 1:40 PM, Peter Maydell wrote: > > > If you do this after the point where we make the source path absolute, you > > can skip the realpath (which avoids the problem that 'realpath' doesn't > > exist >

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Eric Blake
On 3/15/19 1:40 PM, Peter Maydell wrote: > If you do this after the point where we make the source path absolute, you > can skip the realpath (which avoids the problem that 'realpath' doesn't exist > on OSX by default). It will also then be after the handling of the > --source-path option

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Eric Blake
On 3/15/19 12:50 PM, Antonio Ospite wrote: > From: Antonio Ospite > > The configure script breaks when the qemu source directory is in a path > containing white spaces, in particular the list of targets is not > correctly generated when calling "./configure --help". > > To avoid this issue,

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 18:26, Antonio Ospite wrote: > > From: Antonio Ospite > > The configure script breaks when the qemu source directory is in a path > containing white spaces, in particular the list of targets is not > correctly generated when calling "./configure --help". > > To avoid this

[Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Antonio Ospite
From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help". To avoid this issue, refuse to run the configure script if there are spaces or