Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2015 at 3:51 AM, Eric Blake wrote: > On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > > NACK. 'type' is POSIX,

[Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread marcandre . lureau
From: Marc-André Lureau "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) Signed-off-by: Marc-André Lureau --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2015 at 1:53 AM, wrote: > From: Marc-André Lureau > > "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > A subsidiary question is whether qemu really care about using POSIX shell, or we can just

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Eric Blake
On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) NACK. 'type' is POSIX, and shellcheck is buggy.

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Eric Blake
On 12/09/2015 05:57 PM, Marc-André Lureau wrote: > Hi > > On Thu, Dec 10, 2015 at 1:53 AM, wrote: >> From: Marc-André Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) >> > > A subsidiary question is