Re: [Qemu-devel] [PATCH] cpu: Clean up includes

2016-01-18 Thread Eric Blake
On 01/18/2016 11:05 AM, Peter Maydell wrote: >>> +++ b/qom/cpu.c >>> @@ -18,6 +18,7 @@ >>> * >>> */ >>> >>> +#include "qemu/osdep.h" >>> #include "qemu-common.h" >> >> Shouldn't qemu-common.h include osdep.h? > > It does, but the intention is that e

Re: [Qemu-devel] [PATCH] cpu: Clean up includes

2016-01-18 Thread Peter Maydell
On 18 January 2016 at 18:00, Andreas Färber wrote: > Am 18.01.2016 um 18:35 schrieb Peter Maydell: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] cpu: Clean up includes

2016-01-18 Thread Andreas Färber
Am 18.01.2016 um 18:35 schrieb Peter Maydell: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > qom/cpu.c | 1 + > target-i386/

[Qemu-devel] [PATCH] cpu: Clean up includes

2016-01-18 Thread Peter Maydell
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Peter Maydell --- qom/cpu.c | 1 + target-i386/cpu.c | 5 + 2 files changed, 2 insertions(+), 4 deletions(-