Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Longpeng (Mike)
On 2017/11/7 17:16, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 10:27:10AM +0800, Longpeng (Mike) wrote: >> >> >> On 2017/11/7 1:00, Eric Blake wrote: >> >>> On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with errp=NULL, t

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 10:27:10AM +0800, Longpeng (Mike) wrote: > > > On 2017/11/7 1:00, Eric Blake wrote: > > > On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: > >> Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with > >> errp=NULL, this will cause a NULL poniter deference if afalg_dri

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Longpeng (Mike)
On 2017/11/7 1:00, Eric Blake wrote: > On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: >> Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with >> errp=NULL, this will cause a NULL poniter deference if afalg_driver > > s/poniter deference/pointer dereference/ > OK. >> doesn't support r

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Longpeng (Mike)
On 2017/11/7 1:18, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 02:21:11PM +0800, Longpeng(Mike) wrote: >> Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with >> errp=NULL, this will cause a NULL poniter deference if afalg_driver >> doesn't support requested algos: >> ret = qcr

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Stefan Hajnoczi
On Mon, Nov 06, 2017 at 02:21:11PM +0800, Longpeng(Mike) wrote: > Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with > errp=NULL, this will cause a NULL poniter deference if afalg_driver > doesn't support requested algos: > ret = qcrypto_hash_afalg_driver.hash_bytesv(alg, iov, niov,

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Eric Blake
On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: > Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with > errp=NULL, this will cause a NULL poniter deference if afalg_driver s/poniter deference/pointer dereference/ > doesn't support requested algos: > ret = qcrypto_hash_afalg_driver.has

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-06 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, November 06, 2017 2:21 PM > To: berra...@redhat.com; pbonz...@redhat.com; Gonglei (Arei) > Cc: longpeng; qemu-devel@nongnu.org > Subject: [PATCH] crypto: afalg: fix a NULL pointer dereference > > Test-crypto-hash calls qcrypto_hash_byt

[Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-05 Thread Longpeng(Mike)
Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with errp=NULL, this will cause a NULL poniter deference if afalg_driver doesn't support requested algos: ret = qcrypto_hash_afalg_driver.hash_bytesv(alg, iov, niov, result, resultlen,