Re: [Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-28 Thread Juan Quintela
Haozhong Zhang wrote: > On 06/28/17 11:09 +0200, Juan Quintela wrote: >> Haozhong Zhang wrote: >> > In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd >> > argument 'start' is relative to the start of the ramblock 'rb'. When >> > it's used to access the dirty memory bitmap of ram_l

Re: [Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-28 Thread Haozhong Zhang
On 06/28/17 11:09 +0200, Juan Quintela wrote: > Haozhong Zhang wrote: > > In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd > > argument 'start' is relative to the start of the ramblock 'rb'. When > > it's used to access the dirty memory bitmap of ram_list (i.e. > > ram_list.dirty_

Re: [Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-28 Thread Juan Quintela
Haozhong Zhang wrote: > In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd > argument 'start' is relative to the start of the ramblock 'rb'. When > it's used to access the dirty memory bitmap of ram_list (i.e. > ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]->blocks[]), an offset to

Re: [Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-28 Thread Paolo Bonzini
On 28/06/2017 09:30, Juan Quintela wrote: > Haozhong Zhang wrote: >> In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd >> argument 'start' is relative to the start of the ramblock 'rb'. When >> it's used to access the dirty memory bitmap of ram_list (i.e. >> ram_list.dirty_memory

Re: [Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-28 Thread Juan Quintela
Haozhong Zhang wrote: > In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd > argument 'start' is relative to the start of the ramblock 'rb'. When > it's used to access the dirty memory bitmap of ram_list (i.e. > ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]->blocks[]), an offset to

[Qemu-devel] [PATCH] exec: fix access to ram_list.dirty_memory when sync dirty bitmap

2017-06-27 Thread Haozhong Zhang
In cpu_physical_memory_sync_dirty_bitmap(rb, start, ...), the 2nd argument 'start' is relative to the start of the ramblock 'rb'. When it's used to access the dirty memory bitmap of ram_list (i.e. ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION]->blocks[]), an offset to the start of all RAM (i.e. rb->