Re: [Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-08-13 Thread Kevin Wolf
Am 13.08.2018 um 03:45 hat Fam Zheng geschrieben: > On Fri, 08/10 14:14, Kevin Wolf wrote: > > Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben: > > > If we know we've already locked the bytes, don't do it again; similarly > > > don't unlock a byte if we haven't locked it. This doesn't change the

Re: [Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-08-12 Thread Fam Zheng
On Fri, 08/10 14:14, Kevin Wolf wrote: > Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben: > > If we know we've already locked the bytes, don't do it again; similarly > > don't unlock a byte if we haven't locked it. This doesn't change the > > behavior, but fixes a corner case explained below. > >

Re: [Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-08-10 Thread Kevin Wolf
Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben: > If we know we've already locked the bytes, don't do it again; similarly > don't unlock a byte if we haven't locked it. This doesn't change the > behavior, but fixes a corner case explained below. > > Libvirt had an error handling bug that an

[Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-07-18 Thread Fam Zheng
If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELinux) permissions