Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-11-01 Thread Stefan Hajnoczi
On Mon, Oct 31, 2011 at 11:28:45PM +0530, Aneesh Kumar K.V wrote: On Mon, 31 Oct 2011 11:49:33 +, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Markus Armbruster arm...@redhat.com sent fixes for va_list vararg issues in v9fs_string_alloc_printf(). It turns out the function

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-11-01 Thread Aneesh Kumar K.V
On Tue, 1 Nov 2011 07:50:51 +, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Mon, Oct 31, 2011 at 11:28:45PM +0530, Aneesh Kumar K.V wrote: On Mon, 31 Oct 2011 11:49:33 +, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Markus Armbruster arm...@redhat.com sent fixes

[Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-10-31 Thread Stefan Hajnoczi
Markus Armbruster arm...@redhat.com sent fixes for va_list vararg issues in v9fs_string_alloc_printf(). It turns out the function duplicates g_vasprintf() and can therefore be eliminated entirely. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p.c | 103

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-10-31 Thread Markus Armbruster
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: Markus Armbruster arm...@redhat.com sent fixes for va_list vararg issues in v9fs_string_alloc_printf(). It turns out the function duplicates g_vasprintf() and can therefore be eliminated entirely. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-10-31 Thread Aneesh Kumar K.V
On Mon, 31 Oct 2011 11:49:33 +, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Markus Armbruster arm...@redhat.com sent fixes for va_list vararg issues in v9fs_string_alloc_printf(). It turns out the function duplicates g_vasprintf() and can therefore be eliminated entirely.