Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

Peter Maydell writes: > On 9 November 2015 at 18:52, Markus Armbruster wrote: >> Peter Maydell writes: >>> Thanks, I had missed this useful improvement to the API. >>> How does it work in cases like this where we don't have

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On 9 November 2015 at 18:52, Markus Armbruster wrote: > Peter Maydell writes: >> Thanks, I had missed this useful improvement to the API. >> How does it work in cases like this where we don't have >> an Error* to fill in? > > You do what

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On 10 November 2015 at 09:39, Markus Armbruster wrote: > Peter Maydell writes: >> ...so in conclusion Andrew's patch is correct as it stands >> and I should just apply it? :-) > > Yes. It got my R-by :) OK, applied to target-arm.next. Thanks for

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On Tue, Nov 10, 2015 at 11:55:55AM +, Peter Maydell wrote: > On 10 November 2015 at 09:39, Markus Armbruster wrote: > > Peter Maydell writes: > >> ...so in conclusion Andrew's patch is correct as it stands > >> and I should just apply it? :-) > >

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

Peter Maydell writes: > On 9 November 2015 at 10:21, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 9 November 2015 at 07:44, Markus Armbruster wrote: For consistency, error messages

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On 9 November 2015 at 10:21, Markus Armbruster wrote: > Peter Maydell writes: > >> On 9 November 2015 at 07:44, Markus Armbruster wrote: >>> For consistency, error messages should be a phrase, not a full sentence, >>> let alone a

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

Peter Maydell writes: > On 9 November 2015 at 07:44, Markus Armbruster wrote: >> For consistency, error messages should be a phrase, not a full sentence, >> let alone a paraphraph. > > This is in direct conflict with wanting them to be actually

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On 9 November 2015 at 07:44, Markus Armbruster wrote: > For consistency, error messages should be a phrase, not a full sentence, > let alone a paraphraph. This is in direct conflict with wanting them to be actually useful to users :-( thanks -- PMM

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

Peter Maydell writes: > On 7 November 2015 at 15:25, Andrew Jones wrote: >> Signed-off-by: Andrew Jones >> --- >> hw/arm/virt.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git

[Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

Signed-off-by: Andrew Jones --- hw/arm/virt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 77d9267599b7e..9c6792cea16f6 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -941,8 +941,8 @@ static void

Re: [Qemu-devel] [PATCH] hw/arm/virt: error_report cleanups

On 7 November 2015 at 15:25, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 77d9267599b7e..9c6792cea16f6