Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread xiaoqiang zhao
> 在 2016年6月2日，03:44，Mark Cave-Ayland 写道： > >> On 01/06/16 08:58, xiaoqiang zhao wrote: >> >> The previous commit e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9 >> (hw/char: QOM'ify escc.c) cause qemu-system-ppc/ppc64 >> OpenBIOS to freeze on startup, this commit fix

Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread Mark Cave-Ayland
On 01/06/16 08:58, xiaoqiang zhao wrote: > The previous commit e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9 > (hw/char: QOM'ify escc.c) cause qemu-system-ppc/ppc64 > OpenBIOS to freeze on startup, this commit fix it. > > Signed-off-by: xiaoqiang zhao > --- > hw/char/escc.c | 12

Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread Paolo Bonzini
On 01/06/2016 14:33, Mark Cave-Ayland wrote: > > + > > +memory_region_init_io(>mmio, OBJECT(dev), _mem_ops, s, "escc", > > + ESCC_SIZE << s->it_shift); > > + > > for (i = 0; i < 2; i++) { > > if (s->chn[i].chr) { > > +s->chn[i].clock =

Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread xiaoqiang zhao
在 2016年6月1日，20:33，Mark Cave-Ayland 写道： >> for (i = 0; i < 2; i++) { >> if (s->chn[i].chr) { >> +s->chn[i].clock = s->frequency / 2; > > Should this not still be in escc_init1() since s->frequency is set by a > property? You are right!

Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread Mark Cave-Ayland
On 01/06/16 08:58, xiaoqiang zhao wrote: > The previous commit e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9 > (hw/char: QOM'ify escc.c) cause qemu-system-ppc/ppc64 > OpenBIOS to freeze on startup, this commit fix it. > > Signed-off-by: xiaoqiang zhao > --- > hw/char/escc.c | 12

[Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)

2016-06-01 Thread xiaoqiang zhao
The previous commit e7c9136977cb99c6eb52c9139f7b8d8b5fa87db9 (hw/char: QOM'ify escc.c) cause qemu-system-ppc/ppc64 OpenBIOS to freeze on startup, this commit fix it. Signed-off-by: xiaoqiang zhao --- hw/char/escc.c | 12 +++- 1 file changed, 7 insertions(+), 5