Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-02 Thread Gerd Hoffmann
Hi, > In any case this whole array ought at some point to be > replaced with a Q_KEY code to ADB code lookup -- at the > moment we will convert Q_KEY to pc scancode to ADB code, > which is unfortunate if the pc scancodes don't include > some keys that ADB and the host keyboard do. (In fact, >

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 7:38 AM, Peter Maydell wrote: > On 2 March 2016 at 00:31, Programmingkid wrote: >> >> On Mar 1, 2016, at 6:34 PM, Peter Maydell wrote: >> >>> On 1 March 2016 at 22:10, Programmingkid wrote: The pc_to_adb_keycode

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-02 Thread Peter Maydell
On 2 March 2016 at 00:31, Programmingkid wrote: > > On Mar 1, 2016, at 6:34 PM, Peter Maydell wrote: > >> On 1 March 2016 at 22:10, Programmingkid wrote: >>> The pc_to_adb_keycode array was not very easy to work with. The replacement >>>

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 6:34 PM, Peter Maydell wrote: > On 1 March 2016 at 22:10, Programmingkid wrote: >> The pc_to_adb_keycode array was not very easy to work with. The replacement >> array number_to_adb_keycode list all the element indexes on the left and its >> value

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 22:10, Programmingkid wrote: > The pc_to_adb_keycode array was not very easy to work with. The replacement > array number_to_adb_keycode list all the element indexes on the left and its > value on the right. This makes finding a particular index or

[Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Programmingkid
The pc_to_adb_keycode array was not very easy to work with. The replacement array number_to_adb_keycode list all the element indexes on the left and its value on the right. This makes finding a particular index or the meaning for that index very easy. Signed-off-by: John Arbuckle