Re: [Qemu-devel] [PATCH] hw/pci-host/ppce500: Fix typo in vmstate definition

2014-05-30 Thread Alexander Graf
On 29.05.14 13:05, Peter Maydell wrote: Fix a typo in the ppce500_pci vmstate definition which meant that we were migrating the struct pci_inbound using the vmstate for pci_outbound. Fortunately the two structures have exactly the same format at the moment (four uint32_ts) so this was harmless,

Re: [Qemu-devel] [PATCH] hw/pci-host/ppce500: Fix typo in vmstate definition

2014-05-30 Thread Peter Maydell
On 30 May 2014 09:19, Alexander Graf ag...@suse.de wrote: Ouch. I'm fairly sure we don't have migration users on e500, so we're safe. Thanks a lot for catching this! Thank clang 3.4, which noticed that the vmstate_pci_inbound variable was never used... -- PMM

[Qemu-devel] [PATCH] hw/pci-host/ppce500: Fix typo in vmstate definition

2014-05-29 Thread Peter Maydell
Fix a typo in the ppce500_pci vmstate definition which meant that we were migrating the struct pci_inbound using the vmstate for pci_outbound. Fortunately the two structures have exactly the same format at the moment (four uint32_ts) so this was harmless, and we can correcting the typo without a