Re: [Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-19 Thread Markus Armbruster
Thomas Huth writes: > The part of the documentation of DeviceClass that talks about instance_init > is partly wrong: instance_init() functions must not abort or exit, since > the function is also called during introspection of the device already. I figure it was correct back when the comment was

Re: [Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-10 Thread Andreas Färber
Am 10.09.18 um 10:09 schrieb Thomas Huth: > The part of the documentation of DeviceClass that talks about instance_init > is partly wrong: instance_init() functions must not abort or exit, since > the function is also called during introspection of the device already. > So if a device calls exit()

[Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-10 Thread Thomas Huth
The part of the documentation of DeviceClass that talks about instance_init is partly wrong: instance_init() functions must not abort or exit, since the function is also called during introspection of the device already. So if a device calls exit() during its instance_init() function, QEMU terminat