Re: [Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p()

2016-06-28 Thread Peter Maydell
On 13 June 2016 at 07:55, Aurelien Jarno wrote: > On 2016-06-10 17:10, Peter Maydell wrote: >> Use ldl_le_p() and stl_le_p() instead of le32_to_cpup() and >> cpu_to_le32w(); the former handle misaligned addresses and don't >> need casts, and the latter are deprecated. >> >> Signed-off-by: Peter Ma

Re: [Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p()

2016-06-12 Thread Aurelien Jarno
On 2016-06-10 17:10, Peter Maydell wrote: > Use ldl_le_p() and stl_le_p() instead of le32_to_cpup() and > cpu_to_le32w(); the former handle misaligned addresses and don't > need casts, and the latter are deprecated. > > Signed-off-by: Peter Maydell > --- > hw/sh4/sh_pci.c | 4 ++-- > 1 file chan

Re: [Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p()

2016-06-11 Thread Eric Blake
On 06/10/2016 10:10 AM, Peter Maydell wrote: > Use ldl_le_p() and stl_le_p() instead of le32_to_cpup() and > cpu_to_le32w(); the former handle misaligned addresses and don't > need casts, and the latter are deprecated. > > Signed-off-by: Peter Maydell > --- > hw/sh4/sh_pci.c | 4 ++-- > 1 file c

[Qemu-devel] [PATCH] hw/sh4/sh_pci.c: Use ldl_le_p() and stl_le_p()

2016-06-10 Thread Peter Maydell
Use ldl_le_p() and stl_le_p() instead of le32_to_cpup() and cpu_to_le32w(); the former handle misaligned addresses and don't need casts, and the latter are deprecated. Signed-off-by: Peter Maydell --- hw/sh4/sh_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sh4/