Re: [Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-21 Thread John Snow
On 03/02/2018 12:08 PM, Anton Nefedov wrote: > commit 947858b0 "ide: abort TRIM operation for invalid range" > is incorrect for macio; just ide_dma_error() without doing a callback > is not enough for that errorpath. > > Instead, pass -EINVAL to the callback and handle it there > (see related

Re: [Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-16 Thread John Snow
On 03/16/2018 07:20 AM, Mark Cave-Ayland wrote: > On 05/03/18 21:54, Mark Cave-Ayland wrote: > >> On 02/03/18 17:08, Anton Nefedov wrote: >> >>> commit 947858b0 "ide: abort TRIM operation for invalid range" >>> is incorrect for macio; just ide_dma_error() without doing a callback >>> is not

Re: [Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-16 Thread Mark Cave-Ayland
On 05/03/18 21:54, Mark Cave-Ayland wrote: On 02/03/18 17:08, Anton Nefedov wrote: commit 947858b0 "ide: abort TRIM operation for invalid range" is incorrect for macio; just ide_dma_error() without doing a callback is not enough for that errorpath. Instead, pass -EINVAL to the callback and

Re: [Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-05 Thread Mark Cave-Ayland
On 02/03/18 17:08, Anton Nefedov wrote: commit 947858b0 "ide: abort TRIM operation for invalid range" is incorrect for macio; just ide_dma_error() without doing a callback is not enough for that errorpath. Instead, pass -EINVAL to the callback and handle it there (see related motivation for

[Qemu-devel] [PATCH] ide: fix invalid TRIM range abortion for macio

2018-03-02 Thread Anton Nefedov
commit 947858b0 "ide: abort TRIM operation for invalid range" is incorrect for macio; just ide_dma_error() without doing a callback is not enough for that errorpath. Instead, pass -EINVAL to the callback and handle it there (see related motivation for read/write in 58ac32113). It will however