Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Thomas Huth
On 24.05.2018 17:51, Michael S. Tsirkin wrote: > On Thu, May 24, 2018 at 05:46:05PM +0200, Thomas Huth wrote: >> On 24.05.2018 17:00, Michael S. Tsirkin wrote: >>> On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: On 24.05.2018 16:30, Michael S. Tsirkin wrote: > Right now tests

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2018 at 05:46:05PM +0200, Thomas Huth wrote: > On 24.05.2018 17:00, Michael S. Tsirkin wrote: > > On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: > >> On 24.05.2018 16:30, Michael S. Tsirkin wrote: > >>> Right now tests report OK status if QEMU crashes during cleanup.

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Thomas Huth
On 24.05.2018 17:00, Michael S. Tsirkin wrote: > On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: >> On 24.05.2018 16:30, Michael S. Tsirkin wrote: >>> Right now tests report OK status if QEMU crashes during cleanup. >>> Let's catch that case and fail the test. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2018 at 05:04:56PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, May 24, 2018 at 5:00 PM, Michael S. Tsirkin wrote: > > On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: > >> On 24.05.2018 16:30, Michael S. Tsirkin wrote: > >> > Right now tests

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Peter Maydell
On 24 May 2018 at 15:30, Michael S. Tsirkin wrote: > Right now tests report OK status if QEMU crashes during cleanup. > Let's catch that case and fail the test. > Ha -- I've occasionally wondered why some obvious test failures got reported as OK. Thanks for tracking down what

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Marc-André Lureau
Hi On Thu, May 24, 2018 at 5:00 PM, Michael S. Tsirkin wrote: > On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: >> On 24.05.2018 16:30, Michael S. Tsirkin wrote: >> > Right now tests report OK status if QEMU crashes during cleanup. >> > Let's catch that case and

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2018 at 04:45:31PM +0200, Thomas Huth wrote: > On 24.05.2018 16:30, Michael S. Tsirkin wrote: > > Right now tests report OK status if QEMU crashes during cleanup. > > Let's catch that case and fail the test. > > > > Signed-off-by: Michael S. Tsirkin > > --- > >

Re: [Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Thomas Huth
On 24.05.2018 16:30, Michael S. Tsirkin wrote: > Right now tests report OK status if QEMU crashes during cleanup. > Let's catch that case and fail the test. > > Signed-off-by: Michael S. Tsirkin > --- > tests/libqtest.c | 9 - > 1 file changed, 8 insertions(+), 1

[Qemu-devel] [PATCH] libqtest: fail if child coredumps

2018-05-24 Thread Michael S. Tsirkin
Right now tests report OK status if QEMU crashes during cleanup. Let's catch that case and fail the test. Signed-off-by: Michael S. Tsirkin --- tests/libqtest.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index