Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-23 Thread Laurent Vivier
Le 23/01/2018 à 11:26, Andreas Schwab a écrit : > On Jan 23 2018, Laurent Vivier wrote: > >> And, please, test it (build/run). > > This was tested by bootstrapping openSUSE Factory for RISC-V. I have no doubt on this part, but you should test the "#else" part too, by, for

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-23 Thread Andreas Schwab
On Jan 23 2018, Laurent Vivier wrote: > And, please, test it (build/run). This was tested by bootstrapping openSUSE Factory for RISC-V. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-23 Thread Andreas Schwab
On Jan 23 2018, Laurent Vivier wrote: > Please fix style problem reported by patchew > (or ./scripts/checkpatch.pl) This was mostly copy-pasted from surrounding code. :-) >> @@ -8342,6 +8359,22 @@ abi_long do_syscall(void *cpu_env, int num, abi_long >> arg1, >> }

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-22 Thread Laurent Vivier
Le 22/01/2018 à 18:44, Andreas Schwab a écrit : > This is needed for new architectures like RISC-V which do not provide any > other rename-like syscall. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 33 + > 1 file changed, 33

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-22 Thread Laurent Vivier
Le 22/01/2018 à 18:44, Andreas Schwab a écrit : > This is needed for new architectures like RISC-V which do not provide any > other rename-like syscall. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 33 + > 1 file changed, 33

Re: [Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: mvmk1w9lreq@suse.de Subject: [Qemu-devel] [PATCH] linux-user: implement renameat2 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE

[Qemu-devel] [PATCH] linux-user: implement renameat2

2018-01-22 Thread Andreas Schwab
This is needed for new architectures like RISC-V which do not provide any other rename-like syscall. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 33 + 1 file changed, 33 insertions(+) diff --git a/linux-user/syscall.c

Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-23 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171220002941.14560-1-pal...@dabbelt.com Subject: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-21 Thread Palmer Dabbelt
On Thu, 21 Dec 2017 06:01:25 PST (-0800), peter.mayd...@linaro.org wrote: On 20 December 2017 at 00:29, Palmer Dabbelt wrote: +#if defined(TARGET_NR_renameat2) && defined(__NR_renameat2) +case TARGET_NR_renameat2: +{ +void *p2; +p =

Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-21 Thread Peter Maydell
On 20 December 2017 at 00:29, Palmer Dabbelt wrote: > +#if defined(TARGET_NR_renameat2) && defined(__NR_renameat2) > +case TARGET_NR_renameat2: > +{ > +void *p2; > +p = lock_user_string(arg2); > +p2 = lock_user_string(arg4); > +

Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-21 Thread Bastian Koppelmann
On 12/20/2017 01:29 AM, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > The RISC-V Linux port was recently accept upstream and will be released > as part of 4.15. While working on our glibc port I discovered that > qemu's user-mode emulation doesn't support renameat2, which

[Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-20 Thread Palmer Dabbelt
From: Palmer Dabbelt The RISC-V Linux port was recently accept upstream and will be released as part of 4.15. While working on our glibc port I discovered that qemu's user-mode emulation doesn't support renameat2, which has replaced rename as part of the default system call