Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Eduardo Habkost
On Mon, Oct 17, 2016 at 07:10:01PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Oct 17, 2016 at 01:00:29PM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > >> >> machine_set_p

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Oct 17, 2016 at 01:00:29PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: >> >> machine_set_property() replaces '_' by '-' in the property name. >> >> Except it fails to repl

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Eduardo Habkost
On Mon, Oct 17, 2016 at 01:00:29PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > >> machine_set_property() replaces '_' by '-' in the property name. > >> Except it fails to replace an initial '_'. Screwed up i

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: >> machine_set_property() replaces '_' by '-' in the property name. >> Except it fails to replace an initial '_'. Screwed up in commit >> b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property >

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property > '._-foo-bar' not found". > >

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property > '._-foo-bar' not found". > >

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Eric Blake
On 10/13/2016 11:44 AM, Markus Armbruster wrote: > machine_set_property() replaces '_' by '-' in the property name. > Except it fails to replace an initial '_'. Screwed up in commit > b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property > '._-foo-bar' not found". > > Error messages usi

[Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-13 Thread Markus Armbruster
machine_set_property() replaces '_' by '-' in the property name. Except it fails to replace an initial '_'. Screwed up in commit b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property '._-foo-bar' not found". Error messages using a mangled name rather than the name the user actually wrot