Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Wed, Mar 15, 2017 at 10:36:35AM +, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Markus Armbruster (arm...@redhat.com) wrote: > > >> "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > [...] > >> > I'm confused why we need a 'reset to default' - all we need is

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: [...] >> > I'm confused why we need a 'reset to default' - all we need is the ability >> > to change each parameter, and for the new

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Daniel P. Berrange" writes: > >> > >> > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > >> >> On

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Daniel P. Berrange" writes: >> >> > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: >> >> > }

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > >> > } > >> > if (params->has_tls_creds) { > >> >

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Fri, Mar 03, 2017 at 06:05:15PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Mar 03, 2017 at 03:44:12PM +0100, Markus Armbruster wrote: > >> "Daniel P. Berrange" writes: > >> > >> > On Wed, Mar 01, 2017 at 08:36:03AM

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Daniel P. Berrange" writes: > On Fri, Mar 03, 2017 at 03:44:12PM +0100, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> >> On 03/01/2017 06:32 AM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Fri, Mar 03, 2017 at 03:44:12PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > >> > } > >> > if (params->has_tls_creds) { >

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Daniel P. Berrange" writes: > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: >> > } >> > if (params->has_tls_creds) { >> > g_free(s->parameters.tls_creds); >> > -

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > > } > > if (params->has_tls_creds) { > > g_free(s->parameters.tls_creds); > > -s->parameters.tls_creds = g_strdup(params->tls_creds); > > +if

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

"Daniel P. Berrange" writes: > On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: >> On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: >> > Some of the migration parameters are strings, which default to NULL, >> > eg tls_hostname and tls_creds. >> > >> > The mgmt

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On 03/01/2017 08:48 AM, Daniel P. Berrange wrote: >> >> So now we have a dilemma: do we special case "" here, to be stuck with >> it even if we later add nullable-string support later, or do we go all >> the way to nullable-string support now? We've missed soft freeze for >> 2.9, so my vote is

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On Wed, Mar 01, 2017 at 08:36:03AM -0600, Eric Blake wrote: > On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > > Some of the migration parameters are strings, which default to NULL, > > eg tls_hostname and tls_creds. > > > > The mgmt app will set the tls_creds parameter on both source and

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

On 03/01/2017 06:32 AM, Daniel P. Berrange wrote: > Some of the migration parameters are strings, which default to NULL, > eg tls_hostname and tls_creds. > > The mgmt app will set the tls_creds parameter on both source and target > QEMU instances, in order to trigger use of TLS for migration. >

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170301123223.12489-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters === TEST SCRIPT BEGIN === #!/bin/bash # Testing script

Re: [Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170301123223.12489-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH] migration: allow clearing

[Qemu-devel] [PATCH] migration: allow clearing migration string parameters

Some of the migration parameters are strings, which default to NULL, eg tls_hostname and tls_creds. The mgmt app will set the tls_creds parameter on both source and target QEMU instances, in order to trigger use of TLS for migration. After performing a TLS encrypted migration though, migration